aboutsummaryrefslogtreecommitdiff
path: root/flang/lib/Frontend/CompilerInvocation.cpp
diff options
context:
space:
mode:
authorLouis Dionne <ldionne.2@gmail.com>2021-06-02 10:41:37 -0400
committerLouis Dionne <ldionne.2@gmail.com>2021-06-04 09:55:21 -0400
commita9c9183ca42629fa83cdda297d1d30c7bc1d7c91 (patch)
tree37728dd4b2fff531c92df02072fb8d66fbfb7a62 /flang/lib/Frontend/CompilerInvocation.cpp
parent86c24493ea666a0ef91b7af884d616b0a181e849 (diff)
downloadllvm-a9c9183ca42629fa83cdda297d1d30c7bc1d7c91.zip
llvm-a9c9183ca42629fa83cdda297d1d30c7bc1d7c91.tar.gz
llvm-a9c9183ca42629fa83cdda297d1d30c7bc1d7c91.tar.bz2
[libc++] Use the using_if_exists attribute when provided
As discussed on cfe-dev [1], use the using_if_exists Clang attribute when the compiler supports it. This makes it easier to port libc++ on top of new platforms that don't fully support the C Standard library. Previously, libc++ would fail to build when trying to import a missing declaration in a <cXXXX> header. With the attribute, the declaration will simply not be imported into namespace std, and hence it won't be available for libc++ to use. In many cases, the declarations were *not* actually required for libc++ to work (they were only surfaced for users to use them as std::XXXX), so not importing them into namespace std is acceptable. The same thing could be achieved by conscious usage of `#ifdef` along with platform detection, however that quickly creates a maintenance problem as libc++ is ported to new platforms. Furthermore, this problem is exacerbated when mixed with vendor internal-only platforms, which can lead to difficulties maintaining a downstream fork of the library. For the time being, we only use the using_if_exists attribute when it is supported. At some point in the future, we will start removing #ifdef paths that are unnecessary when the attribute is supported, and folks who need those #ifdef paths will be required to use a compiler that supports the attribute. [1]: http://lists.llvm.org/pipermail/cfe-dev/2020-June/066038.html Differential Revision: https://reviews.llvm.org/D90257
Diffstat (limited to 'flang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions