diff options
author | Vyacheslav Levytskyy <vyacheslav.levytskyy@intel.com> | 2024-06-05 09:56:52 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-06-05 09:56:52 +0200 |
commit | 6d4fb3d3bbecbdfa1c98da3f7e09322abaec5f97 (patch) | |
tree | 850f276b6392a410cd4321fcf18aaae9cb447906 /flang/lib/Frontend/CompilerInvocation.cpp | |
parent | 0977504537b4dd945fd91fe11eb1a3165297e64a (diff) | |
download | llvm-6d4fb3d3bbecbdfa1c98da3f7e09322abaec5f97.zip llvm-6d4fb3d3bbecbdfa1c98da3f7e09322abaec5f97.tar.gz llvm-6d4fb3d3bbecbdfa1c98da3f7e09322abaec5f97.tar.bz2 |
[SPIR-V] Emit valid SPIR-V code for integer sizes other than 8,16,32,64 (#94219)
Only with SPV_INTEL_arbitrary_precision_integers SPIR-V Backend creates
arbitrary sized integer types (<= 64 bits). Without such extension and
according to the SPIR-V specification
`SPIRVGlobalRegistry::getOpTypeInt()` rounds integer sizes other than
8,16,32,64 up, to one of defined by the specification sizes. For the
`DuplicateTracker` class this means that several original LLVM types
(e.g., i2, i4) map to the same "OpTypeInt 8" instruction. This breaks
`DuplicateTracker`'s logic and leads to generation of invalid SPIR-V
code eventually.
For example,
```
define spir_func void @foo(i2 %a, i4 %b) {
entry:
%res2 = tail call i2 @llvm.bitreverse.i2(i2 %a)
%res4 = tail call i4 @llvm.bitreverse.i4(i4 %b)
ret void
}
declare i2 @llvm.bitreverse.i2(i2)
declare i4 @llvm.bitreverse.i4(i4)
```
after translation to SPIR-V would fail during validation (`spirv-val`)
due to two `OpTypeInt 8 0` instructions.
This PR fixes the issue by changing source LLVM type according to the
SPIR-V type that will be used in the emitted code.
Diffstat (limited to 'flang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions