diff options
| author | Rik Huijzer <github@huijzer.xyz> | 2023-11-27 11:17:07 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-11-27 11:17:07 +0100 |
| commit | 56cf3ff479ab70b4d802f935afa64a343b402a73 (patch) | |
| tree | 8e55be5b186884938f7faf29ed58840170c289a3 /flang/lib/Frontend/CompilerInvocation.cpp | |
| parent | 272085f10bfaa33349682a9e4d08c990c159355d (diff) | |
| download | llvm-56cf3ff479ab70b4d802f935afa64a343b402a73.zip llvm-56cf3ff479ab70b4d802f935afa64a343b402a73.tar.gz llvm-56cf3ff479ab70b4d802f935afa64a343b402a73.tar.bz2 | |
[mlir][spirv][doc] Remove duplicate syntax formats (#73386)
Some operations defined their syntax both in the documentation and via
`assemblyFormat`. This leads to two syntax descriptions in the
documentation for SPIR-V, see for example the documentation for
[`spirv.mlir.yield`](https://mlir.llvm.org/docs/Dialects/SPIR-V/#spirvmliryield-spirvyieldop).
Since the `assemblyFormat` is used to generate the actual parsers and
printer implementations, this PR removes the manual syntax descriptions.
(Similar to https://github.com/llvm/llvm-project/pull/73343.)
The strategy that I used to find the duplicates was pretty
uncomplicated. I scrolled through the [SPIR-V
Dialect](https://mlir.llvm.org/docs/Dialects/SPIR-V) to find all
duplicates and then remove the duplicate text from the `td` file.
Note that the `Syntax:` block in the docs is a good proxy for whether
`assemblyFormat` is defined because it will only be generated if the op
has defined `assemblyFormat` (`op.hasAssemblyFormat()`):
https://github.com/llvm/llvm-project/blob/e970652776bd07dbe42be557bf98722749230653/mlir/tools/mlir-tblgen/OpDocGen.cpp#L108-L124
https://github.com/llvm/llvm-project/blob/e970652776bd07dbe42be557bf98722749230653/mlir/tools/mlir-tblgen/OpDocGen.cpp#L197-L199
Related issue https://github.com/llvm/llvm-project/issues/73359.
Diffstat (limited to 'flang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions