diff options
author | Jan Svoboda <jan_svoboda@apple.com> | 2021-01-15 17:55:03 +0100 |
---|---|---|
committer | Jan Svoboda <jan_svoboda@apple.com> | 2021-01-19 09:52:46 +0100 |
commit | 39a2a233f88443e865758ba73c156787c77ead2c (patch) | |
tree | 5e9881897697c2c7468dee1fe487f582371a0bea /flang/lib/Frontend/CompilerInvocation.cpp | |
parent | 831a143e50cac873ec095fc7139a485173ba8c35 (diff) | |
download | llvm-39a2a233f88443e865758ba73c156787c77ead2c.zip llvm-39a2a233f88443e865758ba73c156787c77ead2c.tar.gz llvm-39a2a233f88443e865758ba73c156787c77ead2c.tar.bz2 |
[clang][cli] Parse Lang and CodeGen options separately
This patch moves the parsing of `{Lang,CodeGen}Options` from `parseSimpleArgs` to the original `Parse{Lang,CodeGen}Args` functions.
This ensures all marshalled `LangOptions` are being parsed **after** the call `setLangDefaults`, which in turn enables us to marshall `LangOptions` that somehow depend on the defaults. (In a future patch.)
Now, `CodeGenOptions` need to be parsed **after** `LangOptions`, because `-cl-mad-enable` (a `CodeGenOpt`) depends on the value of `-cl-fast-relaxed-math` and `-cl-unsafe-math-optimizations` (`LangOpts`).
Unfortunately, this removes the nice property that marshalled options get parsed in the exact order they appear in the `.td` file. Now we cannot be sure that a TableGen record referenced in `ImpliedByAnyOf` has already been parsed. This might cause an ordering issues (i.e. reading value of uninitialized variable). I plan to mitigate this by moving each `XxxOpt` group from `parseSimpleArgs` back to their original parsing function. With this setup, if an option from group `A` references option from group `B` in TableGen, the compiler will require us to make the `CompilerInvocation` member for `B` visible in the parsing function for `A`. That's where we notice that `B` didn't get parsed yet.
Reviewed By: Bigcheese
Differential Revision: https://reviews.llvm.org/D94682
Diffstat (limited to 'flang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions