diff options
| author | David Majnemer <david.majnemer@gmail.com> | 2014-03-24 21:43:36 +0000 |
|---|---|---|
| committer | David Majnemer <david.majnemer@gmail.com> | 2014-03-24 21:43:36 +0000 |
| commit | 58e5bee17aa1a0ea0c690f9909f5522541e17f95 (patch) | |
| tree | 56194f2a89abe9de002cb39bf42115400d4d89eb /clang/test/CodeGen/c-strings.c | |
| parent | c89450e0546154f69e1afc9b0bdf5a660ee4d558 (diff) | |
| download | llvm-58e5bee17aa1a0ea0c690f9909f5522541e17f95.zip llvm-58e5bee17aa1a0ea0c690f9909f5522541e17f95.tar.gz llvm-58e5bee17aa1a0ea0c690f9909f5522541e17f95.tar.bz2 | |
MS ABI: Eliminate Duplicate Strings
COFF doesn't have mergeable sections so LLVM/clang's normal tactics for
string deduplication will not have any effect.
To remedy this we place each string inside it's own section and mark
the section as IMAGE_COMDAT_SELECT_ANY. However, we can only do this if the
string has an external name that we can generate from it's contents.
To be compatible with MSVC, we must use their scheme. Otherwise identical
strings in translation units from clang may not be deduplicated with
translation units in MSVC.
This fixes PR18248.
N.B. We will not attempt to do anything with a string literal which is not of
type 'char' or 'wchar_t' because their compiler does not support unicode
string literals as of this date. Further, we avoid doing this if
either -fwritable-strings or -fsanitize=address are present.
This reverts commit r204596.
llvm-svn: 204675
Diffstat (limited to 'clang/test/CodeGen/c-strings.c')
| -rw-r--r-- | clang/test/CodeGen/c-strings.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/clang/test/CodeGen/c-strings.c b/clang/test/CodeGen/c-strings.c index ff86619..d82bc25 100644 --- a/clang/test/CodeGen/c-strings.c +++ b/clang/test/CodeGen/c-strings.c @@ -1,14 +1,18 @@ -// RUN: %clang_cc1 -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK --check-prefix=ITANIUM +// RUN: %clang_cc1 -triple %ms_abi_triple -emit-llvm -o - %s | FileCheck %s --check-prefix=CHECK --check-prefix=MSABI // Should be 3 hello strings, two global (of different sizes), the rest are // shared. // CHECK: @align = global i8 [[ALIGN:[0-9]+]] -// CHECK: @.str = private unnamed_addr constant [6 x i8] c"hello\00" -// CHECK: @f1.x = internal global i8* getelementptr inbounds ([6 x i8]* @.str, i32 0, i32 0) +// ITANIUM: @.str = private unnamed_addr constant [6 x i8] c"hello\00" +// MSABI: @"\01??_C@_05CJBACGMB@hello?$AA@" = linkonce_odr unnamed_addr constant [6 x i8] c"hello\00", align 1 +// ITANIUM: @f1.x = internal global i8* getelementptr inbounds ([6 x i8]* @.str, i32 0, i32 0) +// MSABI: @f1.x = internal global i8* getelementptr inbounds ([6 x i8]* @"\01??_C@_05CJBACGMB@hello?$AA@", i32 0, i32 0) // CHECK: @f2.x = internal global [6 x i8] c"hello\00", align [[ALIGN]] // CHECK: @f3.x = internal global [8 x i8] c"hello\00\00\00", align [[ALIGN]] -// CHECK: @f4.x = internal global %struct.s { i8* getelementptr inbounds ([6 x i8]* @.str, i32 0, i32 0) } +// ITANIUM: @f4.x = internal global %struct.s { i8* getelementptr inbounds ([6 x i8]* @.str, i32 0, i32 0) } +// MSABI: @f4.x = internal global %struct.s { i8* getelementptr inbounds ([6 x i8]* @"\01??_C@_05CJBACGMB@hello?$AA@", i32 0, i32 0) } // CHECK: @x = global [3 x i8] c"ola", align [[ALIGN]] #if defined(__s390x__) @@ -22,7 +26,8 @@ void bar(const char *); // CHECK-LABEL: define void @f0() void f0() { bar("hello"); - // CHECK: call void @bar({{.*}} @.str + // ITANIUM: call void @bar({{.*}} @.str + // MSABI: call void @bar({{.*}} @"\01??_C@_05CJBACGMB@hello?$AA@" } // CHECK-LABEL: define void @f1() |