diff options
author | Greg Clayton <gclayton@apple.com> | 2012-01-14 20:47:38 +0000 |
---|---|---|
committer | Greg Clayton <gclayton@apple.com> | 2012-01-14 20:47:38 +0000 |
commit | 32720b51e22300b66d791755e3bb09821741cd09 (patch) | |
tree | 54c87e87f2def767b1874acec6124fdda56c350a /clang/lib/Serialization/Module.cpp | |
parent | 02b0843684d72360389756cdecd7df08b928939c (diff) | |
download | llvm-32720b51e22300b66d791755e3bb09821741cd09.zip llvm-32720b51e22300b66d791755e3bb09821741cd09.tar.gz llvm-32720b51e22300b66d791755e3bb09821741cd09.tar.bz2 |
<rdar://problem/9731573>
Fixed two double "int close(int fd)" issues found by our file descriptor
interposing library on darwin:
The first is in SBDebugger::SetInputFileHandle (FILE *file, bool transfer_ownership)
where we would give our FILE * to a lldb_private::File object member variable and tell
it that it owned the file descriptor if "transfer_ownership" was true, and then we
would also give it to the communication plug-in that waits for stdin to come in and
tell it that it owned the FILE *. They would both try and close the file.
The seconds was when we use a file descriptor through ConnectionFileDescriptor
where someone else is creating a connection with ConnectionFileDescriptor and a URL
like: "fd://123". We were always taking ownwership of the fd 123, when we shouldn't
be. There is a TODO in the comments that says we should allow URL options to be passed
to be able to specify this later (something like: "fd://123?transer_ownership=1"), but
we can get to this later.
llvm-svn: 148201
Diffstat (limited to 'clang/lib/Serialization/Module.cpp')
0 files changed, 0 insertions, 0 deletions