diff options
| author | yronglin <yronglin777@gmail.com> | 2025-04-16 20:53:25 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-04-16 20:53:25 +0800 |
| commit | d3153ad66c539ad146062b6e65741901e5b5e1cc (patch) | |
| tree | 2e2340c0ef9215149ec7f46256830437e5e547fb /clang/lib/Sema/SemaCodeComplete.cpp | |
| parent | fe4a31d59db7b18dc45c3593bf100c101e725b79 (diff) | |
| download | llvm-d3153ad66c539ad146062b6e65741901e5b5e1cc.zip llvm-d3153ad66c539ad146062b6e65741901e5b5e1cc.tar.gz llvm-d3153ad66c539ad146062b6e65741901e5b5e1cc.tar.bz2 | |
[clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (#135808)
I found this issue when I working on
https://github.com/llvm/llvm-project/pull/107168.
Currently we have many similiar data structures like:
- `std::pair<IdentifierInfo *, SourceLocation>`.
- Element type of `ModuleIdPath`.
- `IdentifierLocPair`.
- `IdentifierLoc`.
This PR unify these data structures to `IdentifierLoc`, moved
`IdentifierLoc` definition to SourceLocation.h, and deleted other
similer data structures.
---------
Signed-off-by: yronglin <yronglin777@gmail.com>
Diffstat (limited to 'clang/lib/Sema/SemaCodeComplete.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaCodeComplete.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clang/lib/Sema/SemaCodeComplete.cpp b/clang/lib/Sema/SemaCodeComplete.cpp index f6ec4cb..1e4e6fd 100644 --- a/clang/lib/Sema/SemaCodeComplete.cpp +++ b/clang/lib/Sema/SemaCodeComplete.cpp @@ -8718,7 +8718,7 @@ static void AddProtocolResults(DeclContext *Ctx, DeclContext *CurContext, } void SemaCodeCompletion::CodeCompleteObjCProtocolReferences( - ArrayRef<IdentifierLocPair> Protocols) { + ArrayRef<IdentifierLoc> Protocols) { ResultBuilder Results(SemaRef, CodeCompleter->getAllocator(), CodeCompleter->getCodeCompletionTUInfo(), CodeCompletionContext::CCC_ObjCProtocolName); @@ -8729,9 +8729,9 @@ void SemaCodeCompletion::CodeCompleteObjCProtocolReferences( // Tell the result set to ignore all of the protocols we have // already seen. // FIXME: This doesn't work when caching code-completion results. - for (const IdentifierLocPair &Pair : Protocols) - if (ObjCProtocolDecl *Protocol = - SemaRef.ObjC().LookupProtocol(Pair.first, Pair.second)) + for (const IdentifierLoc &Pair : Protocols) + if (ObjCProtocolDecl *Protocol = SemaRef.ObjC().LookupProtocol( + Pair.getIdentifierInfo(), Pair.getLoc())) Results.Ignore(Protocol); // Add all protocols. |