diff options
author | Anthony Ha <anthonyha96@gmail.com> | 2024-05-03 11:51:25 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-05-03 11:51:25 -0700 |
commit | 2f58b9aae2d6f1aeaecd98766ef31cebc0dcbb5b (patch) | |
tree | 541e0950889366ccdc301be85df99440a01691e2 /clang/lib/Sema/SemaChecking.cpp | |
parent | f8a9973f8c1ef60281ace6f3cfeb24d9dcd5b3c3 (diff) | |
download | llvm-2f58b9aae2d6f1aeaecd98766ef31cebc0dcbb5b.zip llvm-2f58b9aae2d6f1aeaecd98766ef31cebc0dcbb5b.tar.gz llvm-2f58b9aae2d6f1aeaecd98766ef31cebc0dcbb5b.tar.bz2 |
[lldb] Unify CalculateMD5 return types (#90921)
# Overview
In my previous PR: https://github.com/llvm/llvm-project/pull/88812,
@JDevlieghere suggested to match return types of the various calculate
md5 functions.
This PR achieves that by changing the various calculate md5 functions to
return `llvm::ErrorOr<llvm::MD5::MD5Result>`.
The suggestion was to go for `std::optional<>` but I opted for
`llvm::ErrorOr<>` because local calculate md5 was already possibly
returning `ErrorOr`.
To make sure I didn't break the md5 calculation functionality, I ran
some tests for the gdb remote client, and things seem to work.
# Testing
1. Remote file doesn't exist

1. Remote file differs

1. Remote file matches

## Test gaps
Unfortunately, I had to modify
`lldb/source/Plugins/Platform/MacOSX/PlatformDarwinDevice.cpp` and I
can't test the changes there. Hopefully, the existing test suite / code
review from whomever is reading this will catch any issues.
Co-authored-by: Anthony Ha <antha@microsoft.com>
Diffstat (limited to 'clang/lib/Sema/SemaChecking.cpp')
0 files changed, 0 insertions, 0 deletions