diff options
| author | Sean Silva <silvasean@google.com> | 2020-04-27 17:52:59 -0700 |
|---|---|---|
| committer | Sean Silva <silvasean@google.com> | 2020-04-28 14:00:18 -0700 |
| commit | 9c9f479a7dc10e16fd8032875a477827db4b3b77 (patch) | |
| tree | bd0a3d27152b42aadde8758892f9184f7793365b /clang/lib/Lex/ModuleMap.cpp | |
| parent | 751a554f25a9d8e92b378c870d0fb876db72d54a (diff) | |
| download | llvm-9c9f479a7dc10e16fd8032875a477827db4b3b77.zip llvm-9c9f479a7dc10e16fd8032875a477827db4b3b77.tar.gz llvm-9c9f479a7dc10e16fd8032875a477827db4b3b77.tar.bz2 | |
Make ops with StructAttr's actually verify `isa<TheStruct>`.
Previously, they would only only verify `isa<DictionaryAttr>` on such attrs
which resulted in crashes down the line from code assuming that the
verifier was doing the more thorough check introduced in this patch.
The key change here is for StructAttr to use
`CPred<"$_self.isa<" # name # ">()">` instead of `isa<DictionaryAttr>`.
To test this, introduce struct attrs to the test dialect. Previously,
StructAttr was only being tested by unittests/, which didn't verify how
StructAttr interacted with ODS.
Differential Revision: https://reviews.llvm.org/D78975
Diffstat (limited to 'clang/lib/Lex/ModuleMap.cpp')
0 files changed, 0 insertions, 0 deletions