diff options
author | Ryan Prichard <rprichard@google.com> | 2022-07-21 13:09:48 -0700 |
---|---|---|
committer | Ryan Prichard <rprichard@google.com> | 2022-07-21 17:23:29 -0700 |
commit | 02a25279aedcd959d060bba585adc0fe1cec3782 (patch) | |
tree | 1f630cbf2f852ffb10144023d98dc719826f477f /clang/lib/Lex/ModuleMap.cpp | |
parent | 408a2638fda63b381f8750e16c78bc3c845cfdfd (diff) | |
download | llvm-02a25279aedcd959d060bba585adc0fe1cec3782.zip llvm-02a25279aedcd959d060bba585adc0fe1cec3782.tar.gz llvm-02a25279aedcd959d060bba585adc0fe1cec3782.tar.bz2 |
[Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin
Correct the logic used to set `ATOMIC_*_LOCK_FREE` preprocessor macros not
to rely on the ABI alignment of types. Instead, just assume all those
types are aligned correctly by default since clang uses safe alignment
for `_Atomic` types even if the underlying types are aligned to a lower
boundary by default.
For example, the `long long` and `double` types on x86 are aligned to
32-bit boundary by default. However, `_Atomic long long` and `_Atomic
double` are aligned to 64-bit boundary, therefore satisfying
the requirements of lock-free atomic operations.
This fixes PR #19355 by correcting the value of
`__GCC_ATOMIC_LLONG_LOCK_FREE` on x86, and therefore also fixing
the assumption made in libc++ tests. This also fixes PR #30581 by
applying a consistent logic between the functions used to implement
both interfaces.
Reviewed By: hfinkel, efriedma
Differential Revision: https://reviews.llvm.org/D28213
Diffstat (limited to 'clang/lib/Lex/ModuleMap.cpp')
0 files changed, 0 insertions, 0 deletions