diff options
author | Kristof Umann <kristof.umann@ericsson.com> | 2019-04-19 11:01:35 +0000 |
---|---|---|
committer | Kristof Umann <kristof.umann@ericsson.com> | 2019-04-19 11:01:35 +0000 |
commit | cd3f147439724c73991f667f435bef03508749e4 (patch) | |
tree | b39b21e194e2b459cc644d49101bd1f0473e9677 /clang/lib/Frontend/CompilerInvocation.cpp | |
parent | 99f641ccadcab1e5b98f6ad09a9344855cdf287a (diff) | |
download | llvm-cd3f147439724c73991f667f435bef03508749e4.zip llvm-cd3f147439724c73991f667f435bef03508749e4.tar.gz llvm-cd3f147439724c73991f667f435bef03508749e4.tar.bz2 |
[analyzer] Fix an assertion failure if plugins added dependencies
Ideally, there is no reason behind not being able to depend on checkers that
come from a different plugin (or on builtin checkers) -- however, this is only
possible if all checkers are added to the registry before resolving checker
dependencies. Since I used a binary search in my addDependency method, this also
resulted in an assertion failure (due to CheckerRegistry::Checkers not being
sorted), since the function used by plugins to register their checkers
(clang_registerCheckers) calls addDependency.
This patch resolves this issue by only noting which dependencies have to
established when addDependency is called, and resolves them at a later stage
when no more checkers are added to the registry, by which point
CheckerRegistry::Checkers is already sorted.
Differential Revision: https://reviews.llvm.org/D59461
llvm-svn: 358750
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions