diff options
| author | Nicolas Vasilache <ntv@google.com> | 2020-05-11 12:09:18 -0400 |
|---|---|---|
| committer | Nicolas Vasilache <ntv@google.com> | 2020-05-11 12:29:23 -0400 |
| commit | 6ed61a26c21c2d7cf59b2e6144f78c1407853f6d (patch) | |
| tree | 1597cdc9a45325898d10d5d04d07d246d178e80f /clang/lib/Frontend/CompilerInvocation.cpp | |
| parent | f056dacbd756e3554cff33b7bccd7c3fa9bf6fb1 (diff) | |
| download | llvm-6ed61a26c21c2d7cf59b2e6144f78c1407853f6d.zip llvm-6ed61a26c21c2d7cf59b2e6144f78c1407853f6d.tar.gz llvm-6ed61a26c21c2d7cf59b2e6144f78c1407853f6d.tar.bz2 | |
[mlir] Simplify and better document std.view semantics
This [discussion](https://llvm.discourse.group/t/viewop-isnt-expressive-enough/991/2) raised some concerns with ViewOp.
In particular, the handling of offsets is incorrect and does not match the op description.
Note that with an elemental type change, offsets cannot be part of the type in general because sizeof(srcType) != sizeof(dstType).
Howerver, offset is a poorly chosen term for this purpose and is renamed to byte_shift.
Additionally, for all intended purposes, trying to support non-identity layouts for this op does not bring expressive power but rather increases code complexity.
This revision simplifies the existing semantics and implementation.
This simplification effort is voluntarily restrictive and acts as a stepping stone towards supporting richer semantics: treat the non-common cases as YAGNI for now and reevaluate based on concrete use cases once a round of simplification occurred.
Differential revision: https://reviews.llvm.org/D79541
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions