diff options
| author | Ben Langmuir <blangmuir@apple.com> | 2022-11-16 16:07:34 -0800 |
|---|---|---|
| committer | Ben Langmuir <blangmuir@apple.com> | 2022-11-17 13:47:46 -0800 |
| commit | c4436f675d8f5903303fc13d2c2eff2c5800d49b (patch) | |
| tree | 93f7a10005bd76fcd5bc61e439df6a9a6ae2cb8e /clang/lib/Frontend/CompilerInstance.cpp | |
| parent | 7052164f98a389d06a22ea54b673b25d634aa98a (diff) | |
| download | llvm-c4436f675d8f5903303fc13d2c2eff2c5800d49b.zip llvm-c4436f675d8f5903303fc13d2c2eff2c5800d49b.tar.gz llvm-c4436f675d8f5903303fc13d2c2eff2c5800d49b.tar.bz2 | |
[clang] Use InMemoryModuleCache for readASTFileControlBlock NFC
When a pcm has already been loaded from disk, reuse it from the
InMemoryModuleCache in readASTFileControlBlock. This avoids potentially
reading it again.
As noted in the FIXME, ideally we would also add the module to the cache
if it will be used again later, but that could modify its build state
and we do not have enough context currenlty to know if it's correct.
Differential Revision: https://reviews.llvm.org/D138160
Diffstat (limited to 'clang/lib/Frontend/CompilerInstance.cpp')
| -rw-r--r-- | clang/lib/Frontend/CompilerInstance.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clang/lib/Frontend/CompilerInstance.cpp b/clang/lib/Frontend/CompilerInstance.cpp index 6402f16..79bbf37 100644 --- a/clang/lib/Frontend/CompilerInstance.cpp +++ b/clang/lib/Frontend/CompilerInstance.cpp @@ -252,7 +252,8 @@ static void collectIncludePCH(CompilerInstance &CI, // used here since we're not interested in validating the PCH at this time, // but only to check whether this is a file containing an AST. if (!ASTReader::readASTFileControlBlock( - Dir->path(), FileMgr, CI.getPCHContainerReader(), + Dir->path(), FileMgr, CI.getModuleCache(), + CI.getPCHContainerReader(), /*FindModuleFileExtensions=*/false, Validator, /*ValidateDiagnosticOptions=*/false)) MDC->addFile(Dir->path()); |