diff options
author | Kevin P. Neal <kevin.neal@sas.com> | 2020-07-06 11:52:42 -0400 |
---|---|---|
committer | Kevin P. Neal <kevin.neal@sas.com> | 2020-07-06 13:32:49 -0400 |
commit | 39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4 (patch) | |
tree | 389f93333abbd9c4a85197261613990dd8b8a2b0 /clang/lib/Frontend/CompilerInstance.cpp | |
parent | 2a19672af5d58d9ee9f8d6276b57cb584d295eb6 (diff) | |
download | llvm-39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4.zip llvm-39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4.tar.gz llvm-39d2ae0afb2312a15e4d15a0855b35b4e1c49fc4.tar.bz2 |
[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.
We currently have strict floating point/constrained floating point enabled
for all targets. Constrained SDAG nodes get converted to the regular ones
before reaching the target layer. In theory this should be fine.
However, the changes are exposed to users through multiple clang options
already in use in the field, and the changes are _completely_ _untested_
on almost all of our targets. Bugs have already been found, like
"https://bugs.llvm.org/show_bug.cgi?id=45274".
This patch disables constrained floating point options in clang everywhere
except X86 and SystemZ. A warning will be printed when this happens.
Differential Revision: https://reviews.llvm.org/D80952
Diffstat (limited to 'clang/lib/Frontend/CompilerInstance.cpp')
-rw-r--r-- | clang/lib/Frontend/CompilerInstance.cpp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/clang/lib/Frontend/CompilerInstance.cpp b/clang/lib/Frontend/CompilerInstance.cpp index 9dc9c42..189a030e 100644 --- a/clang/lib/Frontend/CompilerInstance.cpp +++ b/clang/lib/Frontend/CompilerInstance.cpp @@ -933,6 +933,19 @@ bool CompilerInstance::ExecuteAction(FrontendAction &Act) { setAuxTarget(TargetInfo::CreateTargetInfo(getDiagnostics(), TO)); } + if (!getTarget().hasStrictFP()) { + if (getLangOpts().getFPRoundingMode() != + llvm::RoundingMode::NearestTiesToEven) { + getDiagnostics().Report(diag::warn_fe_backend_unsupported_fp_rounding); + getLangOpts().setFPRoundingMode(llvm::RoundingMode::NearestTiesToEven); + } + if (getLangOpts().getFPExceptionMode() != LangOptions::FPE_Ignore) { + getDiagnostics().Report(diag::warn_fe_backend_unsupported_fp_exceptions); + getLangOpts().setFPExceptionMode(LangOptions::FPE_Ignore); + } + // FIXME: can we disable FEnvAccess? + } + // Inform the target of the language options. // // FIXME: We shouldn't need to do this, the target should be immutable once |