diff options
| author | Chuanqi Xu <yedeng.yd@linux.alibaba.com> | 2023-02-08 16:24:39 +0800 |
|---|---|---|
| committer | Chuanqi Xu <yedeng.yd@linux.alibaba.com> | 2023-02-08 16:45:00 +0800 |
| commit | 1782e8f9e882e8f4fb59968ff555c8c93827ea02 (patch) | |
| tree | 6d412b04c388e84cbba292e6d414ff39536c1369 /clang/lib/Frontend/CompilerInstance.cpp | |
| parent | 6d14b11018b4dc89692daee01ab0b5d9fa93ad0f (diff) | |
| download | llvm-1782e8f9e882e8f4fb59968ff555c8c93827ea02.zip llvm-1782e8f9e882e8f4fb59968ff555c8c93827ea02.tar.gz llvm-1782e8f9e882e8f4fb59968ff555c8c93827ea02.tar.bz2 | |
[C++20] [Modules] Allow -fmodule-file=<module-name>=<BMI-Path> for implementation unit and document the behavior
Close https://github.com/llvm/llvm-project/issues/57293.
Previsouly we can't use `-fmodule-file=<module-name>=<BMI-Path>` for
implementation units, it is a bug. Also the behavior of the above option
is not tested nor documented for C++20 Modules. This patch addresses the
2 problems.
Diffstat (limited to 'clang/lib/Frontend/CompilerInstance.cpp')
| -rw-r--r-- | clang/lib/Frontend/CompilerInstance.cpp | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/clang/lib/Frontend/CompilerInstance.cpp b/clang/lib/Frontend/CompilerInstance.cpp index 9c79e85..4a8a6b6 100644 --- a/clang/lib/Frontend/CompilerInstance.cpp +++ b/clang/lib/Frontend/CompilerInstance.cpp @@ -1986,14 +1986,7 @@ CompilerInstance::loadModule(SourceLocation ImportLoc, Module = PP->getHeaderSearchInfo().lookupModule( ModuleName, ImportLoc, /*AllowSearch*/ true, /*AllowExtraModuleMapSearch*/ !IsInclusionDirective); - /// FIXME: perhaps we should (a) look for a module using the module name - // to file map (PrebuiltModuleFiles) and (b) diagnose if still not found? - //if (Module == nullptr) { - // getDiagnostics().Report(ModuleNameLoc, diag::err_module_not_found) - // << ModuleName; - // DisableGeneratingGlobalModuleIndex = true; - // return ModuleLoadResult(); - //} + MM.cacheModuleLoad(*Path[0].first, Module); } else { ModuleLoadResult Result = findOrCompileModuleAndReadAST( |