diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2023-03-01 23:29:45 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2023-03-02 15:50:12 +0100 |
| commit | d812488d3c54c07f24d4bef79e329f17e7f19c3b (patch) | |
| tree | 3454d85b8a295f24d459f0ce5aec716c7fbf1c94 /clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp | |
| parent | 6420daab19e8c95f2481090564508eea1996c4de (diff) | |
| download | llvm-d812488d3c54c07f24d4bef79e329f17e7f19c3b.zip llvm-d812488d3c54c07f24d4bef79e329f17e7f19c3b.tar.gz llvm-d812488d3c54c07f24d4bef79e329f17e7f19c3b.tar.bz2 | |
Call MarkVirtualMembersReferenced on an actual class definition
...rather than on potentially just a declaration.
Without the fix, the newly added clang/test/SemaCXX/warn-undefined-internal.cpp
failed with
> error: 'warning' diagnostics expected but not seen:
> File /home/sbergman/github.com/llvm/llvm-project/clang/test/SemaCXX/warn-undefined-internal.cpp Line 12 (directive at /home/sbergman/github.com/llvm/llvm-project/clang/test/SemaCXX/warn-undefined-internal.cpp:13): function 'test2()::S::f' has internal linkage but is not defined
> error: 'note' diagnostics expected but not seen:
> File /home/sbergman/github.com/llvm/llvm-project/clang/test/SemaCXX/warn-undefined-internal.cpp Line 14 (directive at /home/sbergman/github.com/llvm/llvm-project/clang/test/SemaCXX/warn-undefined-internal.cpp:15): used here
(I ran into this when two LibreOffice Clang plugins produced false positive
warnings, as they relied on Decl::isReferenced() returning true for such virtual
member functions of local classes.)
Differential Revision: https://reviews.llvm.org/D145123
Diffstat (limited to 'clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp')
0 files changed, 0 insertions, 0 deletions