diff options
| author | Ted Kremenek <kremenek@apple.com> | 2011-11-17 23:01:24 +0000 |
|---|---|---|
| committer | Ted Kremenek <kremenek@apple.com> | 2011-11-17 23:01:24 +0000 |
| commit | 8cf47df72f999b0adaeded4b2190978bc992ffc5 (patch) | |
| tree | bab5bff7943e840647820feb4e46f76c89f2fadd /clang/lib/CodeGen/ModuleBuilder.cpp | |
| parent | 250476021f5ab554cc4eb245a6ccfe7bc1236281 (diff) | |
| download | llvm-8cf47df72f999b0adaeded4b2190978bc992ffc5.zip llvm-8cf47df72f999b0adaeded4b2190978bc992ffc5.tar.gz llvm-8cf47df72f999b0adaeded4b2190978bc992ffc5.tar.bz2 | |
Make 'LangOptions' in CompilerInvocation a heap-allocated, reference counted object. I discovered that llvm::RefCountedBase<T> has
a bug where the reference count is copied in the copy constructor, which means that there were cases when the CompilerInvocation
objects created by ASTUnit were actually leaked. When I fixed that bug locally, it showed that a whole bunch of code assumed
that the LangOptions object that was part of CompilerInvocation was still alive. By making it heap-allocated and reference counted,
we can keep it around after the CompilerInvocation object goes away.
As part of this change, change CompilerInvocation:getLangOptions() to return a pointer, acting as another clue that this
object may outlive the CompilerInvocation object.
This commit doesn't fix the CompilerInvocation leak itself. That will come when I commit the fix to llvm::RefCountedBase<T> to
mainline LLVM.
llvm-svn: 144930
Diffstat (limited to 'clang/lib/CodeGen/ModuleBuilder.cpp')
0 files changed, 0 insertions, 0 deletions