diff options
| author | Nigel Perks <nigelp@xmos.com> | 2020-06-24 12:20:29 -0700 |
|---|---|---|
| committer | Erich Keane <erich.keane@intel.com> | 2020-06-24 12:48:17 -0700 |
| commit | dc3f8913d2ad33b1129ea488393e12cc88061aff (patch) | |
| tree | 5a6c0d6c7920a4ac757fd801b6c9138ff41f4774 /clang/lib/CodeGen/CodeGenModule.h | |
| parent | 395920a6149323a17813b384caf6bdb883fd767e (diff) | |
| download | llvm-dc3f8913d2ad33b1129ea488393e12cc88061aff.zip llvm-dc3f8913d2ad33b1129ea488393e12cc88061aff.tar.gz llvm-dc3f8913d2ad33b1129ea488393e12cc88061aff.tar.bz2 | |
Fix crash on XCore on unused inline in EmitTargetMetadata
EmitTargetMetadata passed to emitTargetMD a null pointer as returned
from GetGlobalValue, for an unused inline function which has been
removed from the module at that point.
A FIXME in CodeGenModule.cpp commented that the calling code in
EmitTargetMetadata should be moved into the one target that needs it
(XCore). A review comment agreed. So the calling loop has been moved
into the XCore subclass. The check for null is done in that loop.
Differential Revision: https://reviews.llvm.org/D77068
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 59b27fa32..1ebc907 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -1532,9 +1532,6 @@ private: /// Emit the Clang commandline as llvm.commandline metadata. void EmitCommandLineMetadata(); - /// Emits target specific Metadata for global declarations. - void EmitTargetMetadata(); - /// Emit the module flag metadata used to pass options controlling the /// the backend to LLVM. void EmitBackendOptionsMetadata(const CodeGenOptions CodeGenOpts); |