diff options
author | Hans Wennborg <hans@chromium.org> | 2022-06-02 15:09:39 +0200 |
---|---|---|
committer | Hans Wennborg <hans@chromium.org> | 2022-06-02 15:09:39 +0200 |
commit | d42fe9aa84203a8f51b43a901d72fdc39eea69f7 (patch) | |
tree | 82451da4227cd723158e69514ae66af73d4496de /clang/lib/CodeGen/CodeGenModule.h | |
parent | dfaee3c9cfa17fce6af317ddcae89c6f6550cf94 (diff) | |
download | llvm-d42fe9aa84203a8f51b43a901d72fdc39eea69f7.zip llvm-d42fe9aa84203a8f51b43a901d72fdc39eea69f7.tar.gz llvm-d42fe9aa84203a8f51b43a901d72fdc39eea69f7.tar.bz2 |
Revert "[clang][AIX] add option mdefault-visibility-export-mapping"
This caused assertions, see comment on the code review:
llvm/clang/lib/AST/Decl.cpp:1510:
clang::LinkageInfo clang::LinkageComputer::getLVForDecl(const clang::NamedDecl *, clang::LVComputationKind):
Assertion `D->getCachedLinkage() == LV.getLinkage()' failed.
> The option mdefault-visibility-export-mapping is created to allow
> mapping default visibility to an explicit shared library export
> (e.g. dllexport). Exactly how and if this is manifested is target
> dependent (since it depends on how they map dllexport in the IR).
>
> Three values are provided for the option:
>
> * none: the default and behavior without the option, no additional export linkage information is created.
> * explicit: add the export for entities with explict default visibility from the source, including RTTI
> * all: add the export for all entities with default visibility
>
> This option is useful for targets which do not export symbols as part of
> their usual default linkage behaviour (e.g. AIX), such targets
> traditionally specified such information in external files (e.g. export
> lists), but this mapping allows them to use the visibility information
> typically used for this purpose on other (e.g. ELF) platforms.
>
> Reviewed By: MaskRay
>
> Differential Revision: https://reviews.llvm.org/D126340
This reverts commit 8c8a2679a20f621994fa904bcfc68775e7345edc.
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 2284253..0ac476d 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -798,7 +798,6 @@ public: void setDSOLocal(llvm::GlobalValue *GV) const; - bool shouldMapVisibilityToDLLExport(const NamedDecl *D) const; void setDLLImportDLLExport(llvm::GlobalValue *GV, GlobalDecl D) const; void setDLLImportDLLExport(llvm::GlobalValue *GV, const NamedDecl *D) const; /// Set visibility, dllimport/dllexport and dso_local. |