diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2012-03-30 19:44:53 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2012-03-30 19:44:53 +0000 |
| commit | 8453795255ca34a804e01f5b3c7cb939f41ad20c (patch) | |
| tree | 995276152663add165145dc07f06cae95bc0f1eb /clang/lib/CodeGen/CodeGenModule.h | |
| parent | daa04130ed75e5c42a99bac91ac22306f9af8987 (diff) | |
| download | llvm-8453795255ca34a804e01f5b3c7cb939f41ad20c.zip llvm-8453795255ca34a804e01f5b3c7cb939f41ad20c.tar.gz llvm-8453795255ca34a804e01f5b3c7cb939f41ad20c.tar.bz2 | |
Revert r153723, and its follow-ups r153728 and r153733.
These patches cause us to miscompile and/or reject code with static
function-local variables in an extern-C context. Previously, we were
papering over this as long as the variables are within the same
translation unit, and had not seen any failures in the wild. We still
need a proper fix, which involves mangling static locals inside of an
extern-C block (as GCC already does), but this patch causes pretty
widespread regressions. Firefox, and many other applications no longer
build.
Lots of test cases have been posted to the list in response to this
commit, so there should be no problem reproducing the issues.
llvm-svn: 153768
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 79247c6..5719afb 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -733,7 +733,7 @@ public: llvm::Constant *EmitNullConstantForBase(const CXXRecordDecl *Record); /// Error - Emit a general error that something can't be done. - void Error(SourceLocation loc, const Twine &error); + void Error(SourceLocation loc, StringRef error); /// ErrorUnsupported - Print out an error that codegen doesn't support the /// specified stmt yet. |