diff options
author | Jun Zhang <jun@junz.org> | 2022-06-14 17:36:41 +0800 |
---|---|---|
committer | Jun Zhang <jun@junz.org> | 2022-06-14 18:36:03 +0800 |
commit | 781ee538da1855876b085989a37ec959e3f2ecd1 (patch) | |
tree | 9af25065d90663237fc7ecf096d431db96080387 /clang/lib/CodeGen/CodeGenModule.h | |
parent | 2c4e44752d1dd319e0dedaefac1957d70ecb3c9a (diff) | |
download | llvm-781ee538da1855876b085989a37ec959e3f2ecd1.zip llvm-781ee538da1855876b085989a37ec959e3f2ecd1.tar.gz llvm-781ee538da1855876b085989a37ec959e3f2ecd1.tar.bz2 |
Reland "[CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder"
This reverts commits:
d3ddc251acae631bf5ab4da13878f7e8b5b5a451
d90eecff5c9e7e9f8263de6cd72d70322400829f
This relands below commit with asan fix:
The intent of this patch is to selectively carry some states over to
the Builder so we won't lose the information of the previous symbols.
This used to be several downstream patches of Cling, it aims to fix
errors in Clang Interpreter when trying to use inline functions.
Before this patch:
clang-repl> inline int foo() { return 42;}
clang-repl> int x = foo();
JIT session error: Symbols not found: [ _Z3foov ]
error: Failed to materialize symbols:
{ (main, { x, $.incr_module_1.__inits.0, __orc_init_func.incr_module_1 }) }
Co-authored-by: Axel Naumann <Axel.Naumann@cern.ch>
Signed-off-by: Jun Zhang <jun@junz.org>
Differential Revision: https://reviews.llvm.org/D127730
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 779d94a..cce8e46 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -1486,6 +1486,33 @@ public: void printPostfixForExternalizedDecl(llvm::raw_ostream &OS, const Decl *D) const; + /// Move some lazily-emitted states to the NewBuilder. This is especially + /// essential for the incremental parsing environment like Clang Interpreter, + /// because we'll lose all important information after each repl. + void moveLazyEmissionStates(CodeGenModule *NewBuilder) { + assert(DeferredDeclsToEmit.empty() && + "Should have emitted all decls deferred to emit."); + assert(NewBuilder->DeferredDecls.empty() && + "Newly created module should not have deferred decls"); + std::swap(NewBuilder->DeferredDecls, DeferredDecls); + + assert(NewBuilder->DeferredVTables.empty() && + "Newly created module should not have deferred vtables"); + std::swap(NewBuilder->DeferredVTables, DeferredVTables); + + assert(NewBuilder->MangledDeclNames.empty() && + "Newly created module should not have mangled decl names"); + assert(NewBuilder->Manglings.empty() && + "Newly created module should not have manglings"); + std::swap(NewBuilder->Manglings, Manglings); + + assert(WeakRefReferences.empty() && + "Not all WeakRefRefs have been applied"); + std::swap(NewBuilder->WeakRefReferences, WeakRefReferences); + + std::swap(NewBuilder->TBAA, TBAA); + } + private: llvm::Constant *GetOrCreateLLVMFunction( StringRef MangledName, llvm::Type *Ty, GlobalDecl D, bool ForVTable, |