diff options
| author | David Blaikie <dblaikie@gmail.com> | 2023-07-29 01:54:54 +0000 |
|---|---|---|
| committer | David Blaikie <dblaikie@gmail.com> | 2023-08-14 22:25:42 +0000 |
| commit | 19f2b68095fe727e40079b7c6380b36b6462e691 (patch) | |
| tree | 31b0da203a9f1ab57c0de29da3827238034e0c3a /clang/lib/CodeGen/CodeGenModule.h | |
| parent | a70006c4c581ef3f9b355ec78ec38023faada6c6 (diff) | |
| download | llvm-19f2b68095fe727e40079b7c6380b36b6462e691.zip llvm-19f2b68095fe727e40079b7c6380b36b6462e691.tar.gz llvm-19f2b68095fe727e40079b7c6380b36b6462e691.tar.bz2 | |
Make globals with mutable members non-constant, even in custom sections
Turned out we were making overly simple assumptions about which sections (& section flags) would be used when emitting a global into a custom section. This lead to sections with read-only flags being used for globals of struct types with mutable members.
Fixed by porting the codegen function with the more nuanced handling/checking for mutable members out of codegen for use in the sema code that does this initial checking/mapping to section flags.
Differential Revision: https://reviews.llvm.org/D156726
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 8517b1c..601530a 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -814,8 +814,6 @@ public: return getTBAAAccessInfo(AccessType); } - bool isTypeConstant(QualType QTy, bool ExcludeCtor, bool ExcludeDtor); - bool isPaddedAtomicType(QualType type); bool isPaddedAtomicType(const AtomicType *type); |