diff options
| author | Greg Clayton <gclayton@apple.com> | 2018-12-13 17:24:30 +0000 |
|---|---|---|
| committer | Greg Clayton <gclayton@apple.com> | 2018-12-13 17:24:30 +0000 |
| commit | e55979b1e2af94b9894327f66b36cacf8ebf4017 (patch) | |
| tree | 3fb4595f8f1e2ff67c857a0638d4ce5bb26fb6a0 /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 67dbeb6c6a047f394be1eed8cacfeede0938e60f (diff) | |
| download | llvm-e55979b1e2af94b9894327f66b36cacf8ebf4017.zip llvm-e55979b1e2af94b9894327f66b36cacf8ebf4017.tar.gz llvm-e55979b1e2af94b9894327f66b36cacf8ebf4017.tar.bz2 | |
Fix MinidumpParser::GetFilteredModuleList() and test it
The MinidumpParser::GetFilteredModuleList() code was attempting to iterate through the entire module list and if it found more than one entry for a given module name, it wanted to pick the MinidumpModule with the lowest address. A bug existed where it wasn't doing that due to "exists" variable being inverted. "exists" was set to true if it was inserted, not if it existed. Furthermore, the order of the modules would be modified by sorting all modules from low address to high address (using MinidumpModule::base_of_image). This fix also maintains the original order which means your executable is at index 0 as intended instead of some random shared library.
Tests were added to ensure this functionality doesn't regress.
Differential Revision: https://reviews.llvm.org/D55614
llvm-svn: 349062
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions