aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/CodeGen/CodeGenModule.cpp
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2018-12-13 20:04:27 +0000
committerNikita Popov <nikita.ppv@gmail.com>2018-12-13 20:04:27 +0000
commitdc73a6edde8607cadc94f89ba29012a96dca7d81 (patch)
tree8fe3de7d70876f8a984f5bfb80e32a3c2b7f4472 /clang/lib/CodeGen/CodeGenModule.cpp
parentc2e2dd43f018b5c987572e03465472ccf146359c (diff)
downloadllvm-dc73a6edde8607cadc94f89ba29012a96dca7d81.zip
llvm-dc73a6edde8607cadc94f89ba29012a96dca7d81.tar.gz
llvm-dc73a6edde8607cadc94f89ba29012a96dca7d81.tar.bz2
Reapply "[MemCpyOpt] memset->memcpy forwarding with undef tail"
Currently memcpyopt optimizes cases like memset(a, byte, N); memcpy(b, a, M); to memset(a, byte, N); memset(b, byte, M); if M <= N. Often this allows further simplifications down the line, which drop the first memset entirely. This patch extends this optimization for the case where M > N, but we know that the bytes a[N..M] are undef due to alloca/lifetime.start. This situation arises relatively often for Rust code, because Rust does not initialize trailing structure padding and loves to insert redundant memcpys. This also fixes https://bugs.llvm.org/show_bug.cgi?id=39844. The previous version of this patch did not perform dependency checking properly: While the dependency is checked at the position of the memset, the used size must be that of the memcpy. Previously the size of the memset was used, which missed modification in the region MemSetSize..CopySize, resulting in miscompiles. The added tests cover variations of this issue. Differential Revision: https://reviews.llvm.org/D55120 llvm-svn: 349078
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions