diff options
| author | Serge Pavlov <sepavloff@gmail.com> | 2025-10-24 09:40:29 +0700 | 
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-24 09:40:29 +0700 | 
| commit | bcee0ee68dbdcdd5e07e16303b6a5805814d1dfd (patch) | |
| tree | 028bbbe0b39e076a27adf5cc572f140f3dbaea24 /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 6a0f392bb50d890f13cb961a911be28f965ed4f2 (diff) | |
| download | llvm-bcee0ee68dbdcdd5e07e16303b6a5805814d1dfd.zip llvm-bcee0ee68dbdcdd5e07e16303b6a5805814d1dfd.tar.gz llvm-bcee0ee68dbdcdd5e07e16303b6a5805814d1dfd.tar.bz2 | |
[SDAG] Fix deferring constrained function calls (#153029)
Selection DAG has a more sophisticated execution order representation
than the simple sequence used in IR, so building the DAG can take into
account specific properties of the nodes to better express possible
parallelism. The existing implementation does this for constrained
function calls, some of them are considered as independent, which can
potentially improve the generated code. However this mechanism
incorrectly implies that the calls with exception behavior 'ebIgnore'
cannot raise floating-point exception. The purpose of this change is to
fix the implementation.
In the current implementation, constrained function calls don't
immediately update the DAG root. Instead, the DAG builder collects their
output chains and flushes them when the root is required. Constrained
function calls cannot be moved across calls of external functions and
intrinsics that access floating-point environment, they work as
barriers. Between the barriers, constrained function calls can be
reordered, they may be considered independent from viewpoint of raising
exceptions. For strictfp functions this is possible only if
floating-point trapping is disabled.
This change introduces a new restriction - the calls with default
exception handling cannot not be moved between strictfp function calls.
Otherwise the exceptions raised by such call can disturb the expected
exception sequence. It means that constrained function calls with strict
exception behavior act as barriers for the calls with non-strict
behavior and vice versa. Effectively it means that the entire sequence
of constrained calls in IR is split into "strict" and "non-strict"
regions, in which restrictions on the order of constrained calls are
relaxed, but move from one region to another is not allowed. It agrees
with the representation of strictfp code in high-level languages. For
example, C/C++ strictfp code correspond to blocks where pragma `STDC
FENV_ACCESS ON` is in effect, this restriction should help preserving
the intended semantics.
When floating-point exception trapping is enabled, constrained
intrinsics with 'ebStrict' cannot be reordered, their sequence must be
identical to the original source order. The current implementation does
not distinguish between strictfp modes with trapping and without it.
This change make assumption that the trapping is disabled. It is not
correct in the general case, but is compatible with the existing
implementation.
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions
