diff options
| author | Anna Zaks <ganna@apple.com> | 2015-06-25 23:36:21 +0000 |
|---|---|---|
| committer | Anna Zaks <ganna@apple.com> | 2015-06-25 23:36:21 +0000 |
| commit | a16075cfc9a6fbbc933cf00d0e407a11eb210918 (patch) | |
| tree | 81bb00b812a63a3d1d515ef376b2a6c3b397a2e7 /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 785c075786afef3863c00b3691bab4c678a19fb3 (diff) | |
| download | llvm-a16075cfc9a6fbbc933cf00d0e407a11eb210918.zip llvm-a16075cfc9a6fbbc933cf00d0e407a11eb210918.tar.gz llvm-a16075cfc9a6fbbc933cf00d0e407a11eb210918.tar.bz2 | |
[asan] Do not unset DYLD_ROOT_PATH before calling atos on Darwin
We were unsetting DYLD_ROOT_PATH before calling atos on Darwin in order to
address it not working for symbolicating 32 bit binaries. (atos essentiall
tries to respawn as a 32 bit binary and it's disallowed to respawn if
DYLD_ROOT_PATH is set ... ) However, processes rely on having DYLD_ROOT_PATH
set under certain conditions, so this is not the right fix. In particular, this
always crashes when running ASanified process under the debugger in Xcode with
iOS simulator, which is a very important workflow for us to support.
This patch reverts the unsetting of the DYLD_ROOT_PATH. The correct fix to the
misbehavior on 32-bit binaries should happen inside atos.
http://reviews.llvm.org/D10722
llvm-svn: 240724
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions