diff options
author | Chandler Carruth <chandlerc@gmail.com> | 2015-08-05 18:08:10 +0000 |
---|---|---|
committer | Chandler Carruth <chandlerc@gmail.com> | 2015-08-05 18:08:10 +0000 |
commit | 93205eb966bbcb33a209d29708a7a83f005c1552 (patch) | |
tree | 3577f2826f3240866c3a3739dfdd25be0a1d9427 /clang/lib/CodeGen/CodeGenModule.cpp | |
parent | 8b50e0175f99bef03c0f6b7b6f014f657a6bd5a1 (diff) | |
download | llvm-93205eb966bbcb33a209d29708a7a83f005c1552.zip llvm-93205eb966bbcb33a209d29708a7a83f005c1552.tar.gz llvm-93205eb966bbcb33a209d29708a7a83f005c1552.tar.bz2 |
[TTI] Make the cost APIs in TargetTransformInfo consistently use 'int'
rather than 'unsigned' for their costs.
For something like costs in particular there is a natural "negative"
value, that of savings or saved cost. As a consequence, there is a lot
of code that subtracts or creates negative values based on cost, all of
which is prone to awkwardness or bugs when dealing with an unsigned
type. Similarly, we *never* want these values to wrap, as that would
cause Very Bad code generation (likely percieved as an infinite loop as
we try to emit over 2^32 instructions or some such insanity).
All around 'int' seems a much better fit for these basic metrics. I've
added asserts to ensure that at least the TTI interface never returns
negative numbers here. If we ever have a use case for negative numbers,
we can remove this, but this way a bug where someone used '-1' to
produce a 'very large' cost will be caught by the assert.
This passes all tests, and is also UBSan clean.
No functional change intended.
Differential Revision: http://reviews.llvm.org/D11741
llvm-svn: 244080
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions