diff options
author | Shilei Tian <i@tianshilei.me> | 2024-11-15 16:54:29 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-11-15 16:54:29 -0500 |
commit | 4b50ec43d03d9ba9b43edd9a4743951f6498b964 (patch) | |
tree | 00004a25a7f530453df467bde84adab1ab43332b /clang/lib/CodeGen/CodeGenModule.cpp | |
parent | 34ebfabc34476b73a3d65d3bd046c35ffab411c4 (diff) | |
download | llvm-4b50ec43d03d9ba9b43edd9a4743951f6498b964.zip llvm-4b50ec43d03d9ba9b43edd9a4743951f6498b964.tar.gz llvm-4b50ec43d03d9ba9b43edd9a4743951f6498b964.tar.bz2 |
[Clang] Avoid Using `byval` for `ndrange_t` when emitting `__enqueue_kernel_basic` (#116435)
AMDGPU disabled the use of `byval` for struct argument passing in commit
d77c620. However, when emitting `__enqueue_kernel_basic`, Clang still
adds the
`byval` attribute by default. Emitting the `byval` attribute by default
in this
context doesn’t seem like a good idea, as argument-passing conventions
are
highly target-dependent, and assumptions here could lead to issues. This
PR
removes the addition of the `byval` attribute, aligning the behavior
with other
`__enqueue_kernel_*` functions.
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions