diff options
| author | George Rimar <grimar@accesssoftek.com> | 2018-08-10 06:32:39 +0000 |
|---|---|---|
| committer | George Rimar <grimar@accesssoftek.com> | 2018-08-10 06:32:39 +0000 |
| commit | 00d6f4bd6b09af73c4d9de04cfd517afc1fdaa7b (patch) | |
| tree | c3b70f758203b6448c5cefddad02b6075940eb09 /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | ff08c80efcd5f69b9ac9881699b45fb8aa10f15e (diff) | |
| download | llvm-00d6f4bd6b09af73c4d9de04cfd517afc1fdaa7b.zip llvm-00d6f4bd6b09af73c4d9de04cfd517afc1fdaa7b.tar.gz llvm-00d6f4bd6b09af73c4d9de04cfd517afc1fdaa7b.tar.bz2 | |
[LLD][ELF] - Fix crash when using empty --defsym.
We have a crash issue when handling the empty -defsym.
For parsing this option we are using ScriptParser class which is used
generally for reading the linker script. For empty defsym case, we
pass the empty memory buffer and crash in the place removed in https://reviews.llvm.org/rL336436.
But reverting of the above patch would not help here (we would still crash but a bit later). And
even after fixing the crash we would report something like
"lld.exe: error: -defsym:1: unexpected EOF"
It is probably not the appropriate message because mentions EOF.
I think the issue should be handled on a higher level like this patch does.
So we do not want to pass the empty memory buffer first of all I believe.
Differential revision: https://reviews.llvm.org/D50498
llvm-svn: 339412
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions