aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/CodeGen/CodeGenFunction.cpp
diff options
context:
space:
mode:
authorJason Molenda <jmolenda@apple.com>2012-10-04 22:47:07 +0000
committerJason Molenda <jmolenda@apple.com>2012-10-04 22:47:07 +0000
commitccd41e55f1cd1a2a99bd357076638954f419429a (patch)
tree7093042eeeef422e29e4448976973272005341ca /clang/lib/CodeGen/CodeGenFunction.cpp
parentbfeb28087ae76b6c241a6dc1727429fe8f6f76a7 (diff)
downloadllvm-ccd41e55f1cd1a2a99bd357076638954f419429a.zip
llvm-ccd41e55f1cd1a2a99bd357076638954f419429a.tar.gz
llvm-ccd41e55f1cd1a2a99bd357076638954f419429a.tar.bz2
Ran the sources through the compiler with -Wshadow warnings
enabled after we'd found a few bugs that were caused by shadowed local variables; the most important issue this turned up was a common mistake of trying to obtain a mutex lock for the scope of a code block by doing Mutex::Locker(m_map_mutex); This doesn't assign the lock object to a local variable; it is a temporary that has its dtor called immediately. Instead, Mutex::Locker locker(m_map_mutex); does what is intended. For some reason -Wshadow happened to highlight these as shadowed variables. I also fixed a few obivous and easy shadowed variable issues across the code base but there are a couple dozen more that should be fixed when someone has a free minute. <rdar://problem/12437585> llvm-svn: 165269
Diffstat (limited to 'clang/lib/CodeGen/CodeGenFunction.cpp')
0 files changed, 0 insertions, 0 deletions