aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/CodeGen/CodeGenFunction.cpp
diff options
context:
space:
mode:
authorSam McCall <sam.mccall@gmail.com>2018-10-16 16:48:06 +0000
committerSam McCall <sam.mccall@gmail.com>2018-10-16 16:48:06 +0000
commit818ec5e965d49dd385d16f8a23432375a672363d (patch)
treef1f6a115279d3c2f374cdc85e61b449b92cc6c6d /clang/lib/CodeGen/CodeGenFunction.cpp
parent20841d41e762293b319b1a69b9f3cf72052fd9ee (diff)
downloadllvm-818ec5e965d49dd385d16f8a23432375a672363d.zip
llvm-818ec5e965d49dd385d16f8a23432375a672363d.tar.gz
llvm-818ec5e965d49dd385d16f8a23432375a672363d.tar.bz2
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
Summary: This paves the way for alternative transports (mac XPC, maybe messagepack?), and also generally improves layering: testing ClangdLSPServer becomes less of a pipe dream, we split up the JSONOutput monolith, etc. This isn't a final state, much of what remains in JSONRPCDispatcher can go away, handlers can call reply() on the transport directly, JSONOutput can be renamed to StreamLogger and removed, etc. But this patch is sprawling already. The main observable change (see tests) is that hitting EOF on input is now an error: the client should send the 'exit' notification. This is defensible: the protocol doesn't spell this case out. Reproducing the current behavior for all combinations of shutdown/exit/EOF clutters interfaces. We can iterate on this if desired. Reviewers: jkorous, ioeric, hokein Subscribers: mgorny, ilya-biryukov, MaskRay, arphaman, kadircet, cfe-commits Differential Revision: https://reviews.llvm.org/D53286 llvm-svn: 344620
Diffstat (limited to 'clang/lib/CodeGen/CodeGenFunction.cpp')
0 files changed, 0 insertions, 0 deletions