aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/CodeGen/CodeGenFunction.cpp
diff options
context:
space:
mode:
authorNico Weber <nicolasweber@gmx.de>2015-04-11 23:51:38 +0000
committerNico Weber <nicolasweber@gmx.de>2015-04-11 23:51:38 +0000
commit1c565c31b161898d8ea32bd71c5ab55b5d6d2b83 (patch)
tree122eae39680aa0823699c05bf5d76fb24c4816ed /clang/lib/CodeGen/CodeGenFunction.cpp
parent7ad0bd54d31788c4858cffa6e203cd06260b800b (diff)
downloadllvm-1c565c31b161898d8ea32bd71c5ab55b5d6d2b83.zip
llvm-1c565c31b161898d8ea32bd71c5ab55b5d6d2b83.tar.gz
llvm-1c565c31b161898d8ea32bd71c5ab55b5d6d2b83.tar.bz2
Revert r234581, it might have caused a few miscompiles in Chromium.
If the revert helps, I'll get a repro this Monday. Else I'll put the change back in. llvm-svn: 234700
Diffstat (limited to 'clang/lib/CodeGen/CodeGenFunction.cpp')
-rw-r--r--clang/lib/CodeGen/CodeGenFunction.cpp10
1 files changed, 4 insertions, 6 deletions
diff --git a/clang/lib/CodeGen/CodeGenFunction.cpp b/clang/lib/CodeGen/CodeGenFunction.cpp
index 93f0011..42c3a42 100644
--- a/clang/lib/CodeGen/CodeGenFunction.cpp
+++ b/clang/lib/CodeGen/CodeGenFunction.cpp
@@ -12,7 +12,6 @@
//===----------------------------------------------------------------------===//
#include "CodeGenFunction.h"
-#include "CGCleanup.h"
#include "CGCUDARuntime.h"
#include "CGCXXABI.h"
#include "CGDebugInfo.h"
@@ -244,13 +243,12 @@ void CodeGenFunction::FinishFunction(SourceLocation EndLoc) {
// parameters. Do this in whatever block we're currently in; it's
// important to do this before we enter the return block or return
// edges will be *really* confused.
- bool HasCleanups = EHStack.stable_begin() != PrologueCleanupDepth;
- bool HasOnlyLifetimeMarkers =
- HasCleanups && EHStack.containsOnlyLifetimeMarkers(PrologueCleanupDepth);
- bool EmitRetDbgLoc = !HasCleanups || HasOnlyLifetimeMarkers;
- if (HasCleanups) {
+ bool EmitRetDbgLoc = true;
+ if (EHStack.stable_begin() != PrologueCleanupDepth) {
// Make sure the line table doesn't jump back into the body for
// the ret after it's been at EndLoc.
+ EmitRetDbgLoc = false;
+
if (CGDebugInfo *DI = getDebugInfo())
if (OnlySimpleReturnStmts)
DI->EmitLocation(Builder, EndLoc);