diff options
| author | Frederic Riss <friss@apple.com> | 2018-04-06 04:28:12 +0000 |
|---|---|---|
| committer | Frederic Riss <friss@apple.com> | 2018-04-06 04:28:12 +0000 |
| commit | cd90f878d4156ef1a732cdd64bc67aa88e7ac2ec (patch) | |
| tree | d3f7ce21fce68fe4c55bb70b8556b8a6f93fdd0b /clang/lib/Basic/SourceManager.cpp | |
| parent | 1e989deadd26698a3c6f463aad8d636533835cd2 (diff) | |
| download | llvm-cd90f878d4156ef1a732cdd64bc67aa88e7ac2ec.zip llvm-cd90f878d4156ef1a732cdd64bc67aa88e7ac2ec.tar.gz llvm-cd90f878d4156ef1a732cdd64bc67aa88e7ac2ec.tar.bz2 | |
[debugserver] Fix LC_BUILD_VERSION load command handling.
Summary:
In one of the 2 places the LC_BUILD_VERSION load command is handled, there
is a bug preventing us from actually handling them (the address where to
read the load command was not updated). This patch factors reading the
deployment target load commands into a helper and adds testing for the 2
code paths calling the helper.
The testing is a little bit complicated because the only times those load
commands matter is when debugging a simulator process. I added a new
decorator to check that a specific SDK is available. The actual testing was
fairly easy once I knew how to run a simulated process.
Reviewers: jasonmolenda, labath
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D45298
llvm-svn: 329374
Diffstat (limited to 'clang/lib/Basic/SourceManager.cpp')
0 files changed, 0 insertions, 0 deletions