diff options
author | Evan Cheng <evan.cheng@apple.com> | 2011-02-11 02:28:55 +0000 |
---|---|---|
committer | Evan Cheng <evan.cheng@apple.com> | 2011-02-11 02:28:55 +0000 |
commit | 2da1c9599354c82c1c61fead4d162127bf636f80 (patch) | |
tree | 7154e156b7ec5dedf4607ca81f0b5777190279de /clang/lib/Basic/SourceManager.cpp | |
parent | d5090c16f8b2b3c12bb54ac235af32945357b502 (diff) | |
download | llvm-2da1c9599354c82c1c61fead4d162127bf636f80.zip llvm-2da1c9599354c82c1c61fead4d162127bf636f80.tar.gz llvm-2da1c9599354c82c1c61fead4d162127bf636f80.tar.bz2 |
Fix buggy fcopysign lowering.
This
define float @foo(float %x, float %y) nounwind readnone {
entry:
%0 = tail call float @copysignf(float %x, float %y) nounwind readnone
ret float %0
}
Was compiled to:
vmov s0, r1
bic r0, r0, #-2147483648
vmov s1, r0
vcmpe.f32 s0, #0
vmrs apsr_nzcv, fpscr
it lt
vneglt.f32 s1, s1
vmov r0, s1
bx lr
This fails to copy the sign of -0.0f because it's lost during the float to int
conversion. Also, it's sub-optimal when the inputs are in GPR registers.
Now it uses integer and + or operations when it's profitable. And it's correct!
lsrs r1, r1, #31
bfi r0, r1, #31, #1
bx lr
rdar://8984306
llvm-svn: 125357
Diffstat (limited to 'clang/lib/Basic/SourceManager.cpp')
0 files changed, 0 insertions, 0 deletions