aboutsummaryrefslogtreecommitdiff
path: root/clang/lib/Basic/SourceManager.cpp
diff options
context:
space:
mode:
authorEli Bendersky <eliben@google.com>2013-01-12 00:05:00 +0000
committerEli Bendersky <eliben@google.com>2013-01-12 00:05:00 +0000
commit0cf0cb92473ca0277864ccb90180e55252d10229 (patch)
treeaa61acef2d88e5ce1aae14d3d364d2e98c62cb2d /clang/lib/Basic/SourceManager.cpp
parent91c0e749e36ea70935a2c6bf1d32d624ee51b980 (diff)
downloadllvm-0cf0cb92473ca0277864ccb90180e55252d10229.zip
llvm-0cf0cb92473ca0277864ccb90180e55252d10229.tar.gz
llvm-0cf0cb92473ca0277864ccb90180e55252d10229.tar.bz2
Make ParseIdentifier a public method instead of private.
The MCAsmParser interface defines ParseIdentifier is public. There's no reason whatsoever for AsmParser (which implements the MCAsmParser interface) to hide this method. This is all part of a bigger scheme. Several asm parsing "extensions" use the main parser properly through the MCAsmParser interface. However, GenericAsmParser has much more exclusive access and uses implementation details from the concrete implementation - AsmParser, in which it is also declared as a friend. This makes for overly coupled code, and even makes it hard to split GenericAsmParser into a separate file. There's no reason why GenericAsmParser shouldn't be able to access AsmParser through an abstract interface, as long as it's actually registered as an extension. llvm-svn: 172276
Diffstat (limited to 'clang/lib/Basic/SourceManager.cpp')
0 files changed, 0 insertions, 0 deletions