diff options
author | Yutong Zhu <115899167+YutongZhuu@users.noreply.github.com> | 2025-06-02 07:27:32 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-06-02 07:27:32 -0400 |
commit | 0ada5c7b1a52afb668bc42dd2d5573e5805433d1 (patch) | |
tree | 366cef2cc406abc19407f6d296d3d55e7417addb /clang/lib/Basic/SourceManager.cpp | |
parent | c5a56f74fef788c1b5c947462440a4de2a241094 (diff) | |
download | llvm-0ada5c7b1a52afb668bc42dd2d5573e5805433d1.zip llvm-0ada5c7b1a52afb668bc42dd2d5573e5805433d1.tar.gz llvm-0ada5c7b1a52afb668bc42dd2d5573e5805433d1.tar.bz2 |
[Clang] Separate implicit int conversion on negation sign to new diagnostic group (#139429)
This PR reverts a change made in #126846.
#126846 introduced an ``-Wimplicit-int-conversion`` diagnosis for
```c++
int8_t x = something;
x = -x; // warning here
```
This is technically correct since -x could have a width of 9, but this
pattern is common in codebases.
Reverting this change would also introduce the false positive I fixed in
#126846:
```c++
bool b(signed char c) {
return -c >= 128; // -c can be 128
}
```
This false positive is uncommon, so I think it makes sense to revert the
change.
Diffstat (limited to 'clang/lib/Basic/SourceManager.cpp')
0 files changed, 0 insertions, 0 deletions