diff options
| author | Chelsea Cassanova <chelsea_cassanova@apple.com> | 2024-01-30 12:00:38 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-30 12:00:38 -0800 |
| commit | 733b86d3ff8087f1e267c23eb315bb16e3c6c953 (patch) | |
| tree | 2b639dc35c611104a9214f2699553a90723d0f8f /clang/lib/Basic/FileManager.cpp | |
| parent | 6fecfbc7b62f54bd633e83c22630d7c2a3e5741e (diff) | |
| download | llvm-733b86d3ff8087f1e267c23eb315bb16e3c6c953.zip llvm-733b86d3ff8087f1e267c23eb315bb16e3c6c953.tar.gz llvm-733b86d3ff8087f1e267c23eb315bb16e3c6c953.tar.bz2 | |
[lldb][progress] Correctly check total for deterministic progress (#79912)
The `total` parameter for the constructor for Progress was changed to a
std::optional in https://github.com/llvm/llvm-project/pull/77547. It was originally set to 1 to indicate non-determinisitic progress, but this commit changes this. First, `UINT64_MAX` will again be used for non-deterministic progress, and `Progress` now has a static variable set to this value so that we can use this instead of a magic number.
The member variable `m_total` could be changed to a std::optional as
well, but this means that the `ProgressEventData::GetTotal()` (which is
used for the public API) would
either need to return a std::optional value or it would return some
specific integer to represent non-deterministic progress if `m_total` is
std::nullopt.
Diffstat (limited to 'clang/lib/Basic/FileManager.cpp')
0 files changed, 0 insertions, 0 deletions