diff options
| author | Martin Boehme <mboehme@google.com> | 2020-06-08 15:37:44 +0200 |
|---|---|---|
| committer | Martin Boehme <mboehme@google.com> | 2020-06-12 09:33:42 +0200 |
| commit | 2e92b397ae4bd846d34d151749ef09c1a1b81dab (patch) | |
| tree | a9be0b59f5bd56d8802150c9ee7bada427d5da08 /clang/lib/AST/JSONNodeDumper.cpp | |
| parent | 012909dcaf852d4260decd04a76dfe45e7d329c0 (diff) | |
| download | llvm-2e92b397ae4bd846d34d151749ef09c1a1b81dab.zip llvm-2e92b397ae4bd846d34d151749ef09c1a1b81dab.tar.gz llvm-2e92b397ae4bd846d34d151749ef09c1a1b81dab.tar.bz2 | |
[clang] Rename Decl::isHidden() to isUnconditionallyVisible().
Also invert the sense of the return value.
As pointed out by the FIXME that this change resolves, isHidden() wasn't
a very accurate name for this function.
I haven't yet changed any of the strings that are output in
ASTDumper.cpp / JSONNodeDumper.cpp / TextNodeDumper.cpp in response to
whether isHidden() is set because
a) I'm not sure whether it's actually desired to change these strings
(would appreciate feedback on this), and
b) In any case, I'd like to get this pure rename out of the way first,
without any changes to tests. Changing the strings that are output in
the various ...Dumper.cpp files will require changes to quite a few
tests, and I'd like to make those in a separate change.
Differential Revision: https://reviews.llvm.org/D81392
Reviewed By: rsmith
Diffstat (limited to 'clang/lib/AST/JSONNodeDumper.cpp')
| -rw-r--r-- | clang/lib/AST/JSONNodeDumper.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/AST/JSONNodeDumper.cpp b/clang/lib/AST/JSONNodeDumper.cpp index d91172b..f3c5cfa 100644 --- a/clang/lib/AST/JSONNodeDumper.cpp +++ b/clang/lib/AST/JSONNodeDumper.cpp @@ -111,7 +111,7 @@ void JSONNodeDumper::Visit(const Decl *D) { JOS.attribute("isReferenced", true); if (const auto *ND = dyn_cast<NamedDecl>(D)) - attributeOnlyIfTrue("isHidden", ND->isHidden()); + attributeOnlyIfTrue("isHidden", !ND->isUnconditionallyVisible()); if (D->getLexicalDeclContext() != D->getDeclContext()) { // Because of multiple inheritance, a DeclContext pointer does not produce |