diff options
author | Haojian Wu <hokein.wu@gmail.com> | 2020-04-12 23:06:00 +0200 |
---|---|---|
committer | Haojian Wu <hokein.wu@gmail.com> | 2020-04-15 16:15:20 +0200 |
commit | 17198dfaff53a897edfc8d440a91cb9430982dcf (patch) | |
tree | 673ddf106892507ec9540bf9457028aef24d9390 /clang/lib/AST/ComputeDependence.cpp | |
parent | c3c67e95310fe6627b972b0bcc13c25fc36a8e51 (diff) | |
download | llvm-17198dfaff53a897edfc8d440a91cb9430982dcf.zip llvm-17198dfaff53a897edfc8d440a91cb9430982dcf.tar.gz llvm-17198dfaff53a897edfc8d440a91cb9430982dcf.tar.bz2 |
[AST] Fix recovery-expr crash on invalid aligned attr.
Summary:
crash stack:
```
lang: tools/clang/include/clang/AST/AttrImpl.inc:1490: unsigned int clang::AlignedAttr::getAlignment(clang::ASTContext &) const: Assertion `!isAlignmentDependent()' failed.
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0. Program arguments: ./bin/clang -cc1 -std=c++1y -ast-dump -frecovery-ast -fcxx-exceptions /tmp/t4.cpp
1. /tmp/t4.cpp:3:31: current parser token ';'
#0 0x0000000002530cff llvm::sys::PrintStackTrace(llvm::raw_ostream&) llvm-project/llvm/lib/Support/Unix/Signals.inc:564:13
#1 0x000000000252ee30 llvm::sys::RunSignalHandlers() llvm-project/llvm/lib/Support/Signals.cpp:69:18
#2 0x000000000253126c SignalHandler(int) llvm-project/llvm/lib/Support/Unix/Signals.inc:396:3
#3 0x00007f86964d0520 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x13520)
#4 0x00007f8695f9ff61 raise /build/glibc-oCLvUT/glibc-2.29/signal/../sysdeps/unix/sysv/linux/raise.c:51:1
#5 0x00007f8695f8b535 abort /build/glibc-oCLvUT/glibc-2.29/stdlib/abort.c:81:7
#6 0x00007f8695f8b40f _nl_load_domain /build/glibc-oCLvUT/glibc-2.29/intl/loadmsgcat.c:1177:9
#7 0x00007f8695f98b92 (/lib/x86_64-linux-gnu/libc.so.6+0x32b92)
#8 0x0000000004503d9f llvm::APInt::getZExtValue() const llvm-project/llvm/include/llvm/ADT/APInt.h:1623:5
#9 0x0000000004503d9f clang::AlignedAttr::getAlignment(clang::ASTContext&) const llvm-project/build/tools/clang/include/clang/AST/AttrImpl.inc:1492:0
```
Reviewers: sammccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D78085
Diffstat (limited to 'clang/lib/AST/ComputeDependence.cpp')
-rw-r--r-- | clang/lib/AST/ComputeDependence.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/clang/lib/AST/ComputeDependence.cpp b/clang/lib/AST/ComputeDependence.cpp index 3a326f6..0f0f79e 100644 --- a/clang/lib/AST/ComputeDependence.cpp +++ b/clang/lib/AST/ComputeDependence.cpp @@ -71,8 +71,10 @@ ExprDependence clang::computeDependence(UnaryExprOrTypeTraitExpr *E) { if (!D) return Deps; for (const auto *I : D->specific_attrs<AlignedAttr>()) { + if (I->isAlignmentErrorDependent()) + Deps |= ExprDependence::Error; if (I->isAlignmentDependent()) - return Deps | ExprDependence::ValueInstantiation; + Deps |= ExprDependence::ValueInstantiation; } return Deps; } |