aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTim Keith <tkeith@nvidia.com>2020-12-28 16:36:32 -0800
committerTim Keith <tkeith@nvidia.com>2020-12-28 16:36:34 -0800
commitf782d5ea86f6fc82b51a0de688bf292f39cc4814 (patch)
treea9f52d76c23e2feb2ac2771f043ad0c41359e3c7
parentc0a2d3b90b3b024247cb38f73219ed595e974431 (diff)
downloadllvm-f782d5ea86f6fc82b51a0de688bf292f39cc4814.zip
llvm-f782d5ea86f6fc82b51a0de688bf292f39cc4814.tar.gz
llvm-f782d5ea86f6fc82b51a0de688bf292f39cc4814.tar.bz2
[flang] Detect call to abstract interface
A subroutine call or function reference to an abstract interface is not legal. Differential Revision: https://reviews.llvm.org/D93872
-rw-r--r--flang/lib/Semantics/resolve-names.cpp5
-rw-r--r--flang/test/Semantics/resolve20.f9011
2 files changed, 15 insertions, 1 deletions
diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp
index 73c624a..2412758 100644
--- a/flang/lib/Semantics/resolve-names.cpp
+++ b/flang/lib/Semantics/resolve-names.cpp
@@ -5879,7 +5879,10 @@ void ResolveNamesVisitor::HandleProcedureName(
return; // reported error
}
CheckImplicitNoneExternal(name.source, *symbol);
- if (IsProcedure(*symbol) || symbol->has<DerivedTypeDetails>() ||
+ if (symbol->has<SubprogramDetails>() &&
+ symbol->attrs().test(Attr::ABSTRACT)) {
+ Say(name, "Abstract interface '%s' may not be called"_err_en_US);
+ } else if (IsProcedure(*symbol) || symbol->has<DerivedTypeDetails>() ||
symbol->has<ObjectEntityDetails>() ||
symbol->has<AssocEntityDetails>()) {
// Symbols with DerivedTypeDetails, ObjectEntityDetails and
diff --git a/flang/test/Semantics/resolve20.f90 b/flang/test/Semantics/resolve20.f90
index f9cfc7c..94bd4c1 100644
--- a/flang/test/Semantics/resolve20.f90
+++ b/flang/test/Semantics/resolve20.f90
@@ -61,7 +61,18 @@ module m
procedure(proc), deferred :: p1
end type t1
+ abstract interface
+ function f()
+ end function
+ end interface
+
contains
subroutine bar
end subroutine
+ subroutine test
+ !ERROR: Abstract interface 'foo' may not be called
+ call foo()
+ !ERROR: Abstract interface 'f' may not be called
+ x = f()
+ end subroutine
end module