aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Clayton <gclayton@apple.com>2011-05-23 23:14:34 +0000
committerGreg Clayton <gclayton@apple.com>2011-05-23 23:14:34 +0000
commit49c0fe24d6971da8b41f6a7b545e1fa73941431c (patch)
tree8d659be5599d863e01941659d0f63047f263012b
parent61ae8d395e9d96d8cae82372abd0c2b2c1f8c3eb (diff)
downloadllvm-49c0fe24d6971da8b41f6a7b545e1fa73941431c.zip
llvm-49c0fe24d6971da8b41f6a7b545e1fa73941431c.tar.gz
llvm-49c0fe24d6971da8b41f6a7b545e1fa73941431c.tar.bz2
Don't resolve the path when we extract the path from the dyld info or we
can end up with an invalid path if the path resolves to something different on the local machine. It is very important not to since remote debugging will mention paths that might exist on the current machine (like "/System/Library/Frameworks/CoreFoundation/CoreFoundation" which on the desktop systems is a symlink to "/System/Library/Frameworks/CoreFoundation/Versions/A/CoreFoundation"). We will let the platform plug-ins resolve the paths in a later stage. llvm-svn: 131934
-rw-r--r--lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp7
1 files changed, 3 insertions, 4 deletions
diff --git a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
index be205a7..a498c2e 100644
--- a/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
+++ b/lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
@@ -607,10 +607,9 @@ DynamicLoaderMacOSXDYLD::UpdateAllImageInfos()
char raw_path[PATH_MAX];
m_process->ReadCStringFromMemory (path_addr, raw_path, sizeof(raw_path));
- char raw_path2[PATH_MAX];// TODO: remove after assertion doesn't assert
- m_process->ReadMemory (path_addr, raw_path2, sizeof(raw_path2), error);// TODO: remove after assertion doesn't assert
- assert (strcmp (raw_path, raw_path2) == 0);// TODO: remove after assertion doesn't assert
- m_dyld_image_infos[i].file_spec.SetFile(raw_path, true);
+ // don't resolve the path
+ const bool resolve_path = false;
+ m_dyld_image_infos[i].file_spec.SetFile(raw_path, resolve_path);
}
assert(i == m_dyld_all_image_infos.dylib_info_count);