diff options
| author | John Harrison <harjohn@google.com> | 2025-03-31 15:51:07 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-03-31 15:51:07 -0700 |
| commit | 4492632432190ed8ab3bc39ff8ee5ba9a89256cf (patch) | |
| tree | 8e9bc4630769844e23091f84bbc3b4ff3fe33bc5 | |
| parent | 7793bae97d2bad36d870c6df438a6fc034f15112 (diff) | |
| download | llvm-4492632432190ed8ab3bc39ff8ee5ba9a89256cf.zip llvm-4492632432190ed8ab3bc39ff8ee5ba9a89256cf.tar.gz llvm-4492632432190ed8ab3bc39ff8ee5ba9a89256cf.tar.bz2 | |
[lldb-dap] Do not take ownership of stdin. (#133811)
There isn't any benefit to taking ownership of stdin and it may cause
issues if `Transport` is dealloced.
| -rw-r--r-- | lldb/tools/lldb-dap/lldb-dap.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/tools/lldb-dap/lldb-dap.cpp b/lldb/tools/lldb-dap/lldb-dap.cpp index 062c3a5..b91c62e 100644 --- a/lldb/tools/lldb-dap/lldb-dap.cpp +++ b/lldb/tools/lldb-dap/lldb-dap.cpp @@ -571,9 +571,9 @@ int main(int argc, char *argv[]) { } lldb::IOObjectSP input = std::make_shared<NativeFile>( - fileno(stdin), File::eOpenOptionReadOnly, true); + fileno(stdin), File::eOpenOptionReadOnly, NativeFile::Unowned); lldb::IOObjectSP output = std::make_shared<NativeFile>( - stdout_fd, File::eOpenOptionWriteOnly, false); + stdout_fd, File::eOpenOptionWriteOnly, NativeFile::Unowned); constexpr llvm::StringLiteral client_name = "stdin/stdout"; Transport transport(client_name, log.get(), input, output); |