diff options
| author | Kunqiu Chen <camsyn@foxmail.com> | 2025-10-29 19:39:49 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-10-29 19:39:49 +0800 |
| commit | 356a8114ca796096b9e98a35713afae48ce26337 (patch) | |
| tree | 3db375aa9efc9737d88fbfd85408ad6feb2368b4 | |
| parent | ce7cca116d1338d8427cd6795639d35d71e66028 (diff) | |
| download | llvm-356a8114ca796096b9e98a35713afae48ce26337.zip llvm-356a8114ca796096b9e98a35713afae48ce26337.tar.gz llvm-356a8114ca796096b9e98a35713afae48ce26337.tar.bz2 | |
[PredicateInfo] Drop redundant PredicateInfo annotation (#165434)
See
https://github.com/llvm/llvm-project/pull/165419#discussion_r2470208670
for details.
The extra annotation `"; Has predicate info"` does not provide any extra
information and might poison the UTC-generated checks introduced by
#165419.
| -rw-r--r-- | llvm/lib/Transforms/Utils/PredicateInfo.cpp | 1 | ||||
| -rw-r--r-- | llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll | 4 |
2 files changed, 1 insertions, 4 deletions
diff --git a/llvm/lib/Transforms/Utils/PredicateInfo.cpp b/llvm/lib/Transforms/Utils/PredicateInfo.cpp index a9ab3b3..27fed73 100644 --- a/llvm/lib/Transforms/Utils/PredicateInfo.cpp +++ b/llvm/lib/Transforms/Utils/PredicateInfo.cpp @@ -809,7 +809,6 @@ public: void emitInstructionAnnot(const Instruction *I, formatted_raw_ostream &OS) override { if (const auto *PI = PredInfo->getPredicateInfoFor(I)) { - OS << "; Has predicate info\n"; if (const auto *PB = dyn_cast<PredicateBranch>(PI)) { OS << "; branch predicate info { TrueEdge: " << PB->TrueEdge << " Comparison:" << *PB->Condition << " Edge: ["; diff --git a/llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll b/llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll index d9f6aed..faf4bec 100644 --- a/llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll +++ b/llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll @@ -6,13 +6,11 @@ ; Check we can use ssa.copy with unnamed types. ; CHECK-LABEL: bb: -; CHECK: Has predicate info ; CHECK: branch predicate info { TrueEdge: 1 Comparison: %cmp1 = icmp ne ptr %arg, null Edge: [label %bb,label %bb1], RenamedOp: %arg } ; CHECK-NEXT: %arg.0 = bitcast ptr %arg to ptr ; CHECK-LABEL: bb1: -; CHECK: Has predicate info -; CHECK-NEXT: branch predicate info { TrueEdge: 0 Comparison: %cmp2 = icmp ne ptr null, %tmp Edge: [label %bb1,label %bb3], RenamedOp: %tmp } +; CHECK: branch predicate info { TrueEdge: 0 Comparison: %cmp2 = icmp ne ptr null, %tmp Edge: [label %bb1,label %bb3], RenamedOp: %tmp } ; CHECK-NEXT: %tmp.0 = bitcast ptr %tmp to ptr define void @f0(ptr %arg, ptr %tmp) { |