aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorQi Hu <qi.hu@huawei.com>2023-09-06 16:33:00 -0400
committerBryan Chan <bryan.chan@huawei.com>2023-09-07 10:28:54 -0400
commit1a65cd3fcf5828ecd36fd336de7689ff7a0218a4 (patch)
tree9f546e1d9f1f91d871bd7161809d28774dc5169a
parent149a698589900a41ac21354b6400ca0e8d214cbf (diff)
downloadllvm-1a65cd3fcf5828ecd36fd336de7689ff7a0218a4.zip
llvm-1a65cd3fcf5828ecd36fd336de7689ff7a0218a4.tar.gz
llvm-1a65cd3fcf5828ecd36fd336de7689ff7a0218a4.tar.bz2
[InstCombine] Optimize implementations of min/max for bool
umin.i1 -> and : https://alive2.llvm.org/ce/z/6FNH6k smin.i1 -> or : https://alive2.llvm.org/ce/z/h96S6o umax.i1 -> or : https://alive2.llvm.org/ce/z/XHdeVk smax.i1 -> and : https://alive2.llvm.org/ce/z/fkxKJx umin.v4i1 -> and : https://alive2.llvm.org/ce/z/yV4VgP smin.v4i1 -> or : https://alive2.llvm.org/ce/z/e9TF68 umax.v4i1 -> or : https://alive2.llvm.org/ce/z/tfNyfK smax.v4i1 -> and : https://alive2.llvm.org/ce/z/0__Af2 Reviewed By: goldstein.w.n, bryanpkc Differential Revision: https://reviews.llvm.org/D158915
-rw-r--r--llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp14
-rw-r--r--llvm/test/Transforms/InstCombine/fold-minmax-i1.ll16
2 files changed, 22 insertions, 8 deletions
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
index 6af7e9e..b493dff 100644
--- a/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp
@@ -1630,6 +1630,20 @@ Instruction *InstCombinerImpl::visitCallInst(CallInst &CI) {
}
}
+ // umin(i1 X, i1 Y) -> and i1 X, Y
+ // smax(i1 X, i1 Y) -> and i1 X, Y
+ if ((IID == Intrinsic::umin || IID == Intrinsic::smax) &&
+ II->getType()->isIntOrIntVectorTy(1)) {
+ return BinaryOperator::CreateAnd(I0, I1);
+ }
+
+ // umax(i1 X, i1 Y) -> or i1 X, Y
+ // smin(i1 X, i1 Y) -> or i1 X, Y
+ if ((IID == Intrinsic::umax || IID == Intrinsic::smin) &&
+ II->getType()->isIntOrIntVectorTy(1)) {
+ return BinaryOperator::CreateOr(I0, I1);
+ }
+
if (IID == Intrinsic::smax || IID == Intrinsic::smin) {
// smax (neg nsw X), (neg nsw Y) --> neg nsw (smin X, Y)
// smin (neg nsw X), (neg nsw Y) --> neg nsw (smax X, Y)
diff --git a/llvm/test/Transforms/InstCombine/fold-minmax-i1.ll b/llvm/test/Transforms/InstCombine/fold-minmax-i1.ll
index 44d913d..bf86eef 100644
--- a/llvm/test/Transforms/InstCombine/fold-minmax-i1.ll
+++ b/llvm/test/Transforms/InstCombine/fold-minmax-i1.ll
@@ -8,7 +8,7 @@
define i1 @umin_scalar(i1 %0, i1 %1) {
; CHECK-LABEL: define i1 @umin_scalar
; CHECK-SAME: (i1 [[TMP0:%.*]], i1 [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call i1 @llvm.umin.i1(i1 [[TMP0]], i1 [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = and i1 [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret i1 [[TMP3]]
;
%3 = call i1 @llvm.umin.i1(i1 %0, i1 %1)
@@ -18,7 +18,7 @@ define i1 @umin_scalar(i1 %0, i1 %1) {
define i1 @smin_scalar(i1 %0, i1 %1) {
; CHECK-LABEL: define i1 @smin_scalar
; CHECK-SAME: (i1 [[TMP0:%.*]], i1 [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call i1 @llvm.smin.i1(i1 [[TMP0]], i1 [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = or i1 [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret i1 [[TMP3]]
;
%3 = call i1 @llvm.smin.i1(i1 %0, i1 %1)
@@ -28,7 +28,7 @@ define i1 @smin_scalar(i1 %0, i1 %1) {
define i1 @umax_scalar(i1 %0, i1 %1) {
; CHECK-LABEL: define i1 @umax_scalar
; CHECK-SAME: (i1 [[TMP0:%.*]], i1 [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call i1 @llvm.umax.i1(i1 [[TMP0]], i1 [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = or i1 [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret i1 [[TMP3]]
;
%3 = call i1 @llvm.umax.i1(i1 %0, i1 %1)
@@ -38,7 +38,7 @@ define i1 @umax_scalar(i1 %0, i1 %1) {
define i1 @smax_scalar(i1 %0, i1 %1) {
; CHECK-LABEL: define i1 @smax_scalar
; CHECK-SAME: (i1 [[TMP0:%.*]], i1 [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call i1 @llvm.smax.i1(i1 [[TMP0]], i1 [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = and i1 [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret i1 [[TMP3]]
;
%3 = call i1 @llvm.smax.i1(i1 %0, i1 %1)
@@ -52,7 +52,7 @@ define i1 @smax_scalar(i1 %0, i1 %1) {
define <4 x i1> @umin_vector(<4 x i1> %0, <4 x i1> %1) {
; CHECK-LABEL: define <4 x i1> @umin_vector
; CHECK-SAME: (<4 x i1> [[TMP0:%.*]], <4 x i1> [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call <4 x i1> @llvm.umin.v4i1(<4 x i1> [[TMP0]], <4 x i1> [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = and <4 x i1> [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret <4 x i1> [[TMP3]]
;
%3 = call <4 x i1> @llvm.umin.v4i1(<4 x i1> %0, <4 x i1> %1)
@@ -62,7 +62,7 @@ define <4 x i1> @umin_vector(<4 x i1> %0, <4 x i1> %1) {
define <4 x i1> @smin_vector(<4 x i1> %0, <4 x i1> %1) {
; CHECK-LABEL: define <4 x i1> @smin_vector
; CHECK-SAME: (<4 x i1> [[TMP0:%.*]], <4 x i1> [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call <4 x i1> @llvm.smin.v4i1(<4 x i1> [[TMP0]], <4 x i1> [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = or <4 x i1> [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret <4 x i1> [[TMP3]]
;
%3 = call <4 x i1> @llvm.smin.v4i1(<4 x i1> %0, <4 x i1> %1)
@@ -72,7 +72,7 @@ define <4 x i1> @smin_vector(<4 x i1> %0, <4 x i1> %1) {
define <4 x i1> @umax_vector(<4 x i1> %0, <4 x i1> %1) {
; CHECK-LABEL: define <4 x i1> @umax_vector
; CHECK-SAME: (<4 x i1> [[TMP0:%.*]], <4 x i1> [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call <4 x i1> @llvm.umax.v4i1(<4 x i1> [[TMP0]], <4 x i1> [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = or <4 x i1> [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret <4 x i1> [[TMP3]]
;
%3 = call <4 x i1> @llvm.umax.v4i1(<4 x i1> %0, <4 x i1> %1)
@@ -82,7 +82,7 @@ define <4 x i1> @umax_vector(<4 x i1> %0, <4 x i1> %1) {
define <4 x i1> @smax_vector(<4 x i1> %0, <4 x i1> %1) {
; CHECK-LABEL: define <4 x i1> @smax_vector
; CHECK-SAME: (<4 x i1> [[TMP0:%.*]], <4 x i1> [[TMP1:%.*]]) {
-; CHECK-NEXT: [[TMP3:%.*]] = call <4 x i1> @llvm.smax.v4i1(<4 x i1> [[TMP0]], <4 x i1> [[TMP1]])
+; CHECK-NEXT: [[TMP3:%.*]] = and <4 x i1> [[TMP0]], [[TMP1]]
; CHECK-NEXT: ret <4 x i1> [[TMP3]]
;
%3 = call <4 x i1> @llvm.smax.v4i1(<4 x i1> %0, <4 x i1> %1)