diff options
| author | Torvald Riegel <triegel@redhat.com> | 2015-06-24 14:37:32 +0200 |
|---|---|---|
| committer | Torvald Riegel <triegel@redhat.com> | 2016-01-15 21:20:34 +0100 |
| commit | b02840bacdefde318d2ad2f920e50785b9b25d69 (patch) | |
| tree | dcf8ee01d1e4bdb42686d890c1d00bf3249fbcaf /sysdeps/nptl | |
| parent | a3e5b4feeb54cb92657ec2bc6d9be1fcef9e8575 (diff) | |
| download | glibc-b02840bacdefde318d2ad2f920e50785b9b25d69.zip glibc-b02840bacdefde318d2ad2f920e50785b9b25d69.tar.gz glibc-b02840bacdefde318d2ad2f920e50785b9b25d69.tar.bz2 | |
New pthread_barrier algorithm to fulfill barrier destruction requirements.
The previous barrier implementation did not fulfill the POSIX requirements
for when a barrier can be destroyed. Specifically, it was possible that
threads that haven't noticed yet that their round is complete still access
the barrier's memory, and that those accesses can happen after the barrier
has been legally destroyed.
The new algorithm does not have this issue, and it avoids using a lock
internally.
Diffstat (limited to 'sysdeps/nptl')
| -rw-r--r-- | sysdeps/nptl/internaltypes.h | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/sysdeps/nptl/internaltypes.h b/sysdeps/nptl/internaltypes.h index 74e848f..203c548 100644 --- a/sysdeps/nptl/internaltypes.h +++ b/sysdeps/nptl/internaltypes.h @@ -92,15 +92,18 @@ struct pthread_rwlockattr }; -/* Barrier data structure. */ +/* Barrier data structure. See pthread_barrier_wait for a description + of how these fields are used. */ struct pthread_barrier { - unsigned int curr_event; - int lock; - unsigned int left; - unsigned int init_count; - int private; + unsigned int in; + unsigned int current_round; + unsigned int count; + int shared; + unsigned int out; }; +/* See pthread_barrier_wait for a description. */ +#define BARRIER_IN_THRESHOLD (UINT_MAX/2) /* Barrier variable attribute data structure. */ |