diff options
| author | Sergey Bugaev <bugaevc@gmail.com> | 2023-03-19 18:10:14 +0300 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2023-04-03 01:25:57 +0200 |
| commit | 7b3d8558d92a123743699c577704aab4a2f3d949 (patch) | |
| tree | fe0bb4533bf48e85d1da16240e72bac373ecd030 /hurd | |
| parent | 17841fa7d45c7ce8836a2935255f90f0bfac46b1 (diff) | |
| download | glibc-7b3d8558d92a123743699c577704aab4a2f3d949.zip glibc-7b3d8558d92a123743699c577704aab4a2f3d949.tar.gz glibc-7b3d8558d92a123743699c577704aab4a2f3d949.tar.bz2 | |
hurd: Microoptimize _hurd_self_sigstate ()
When THREAD_GETMEM is defined with inline assembly, the compiler may not
optimize away the two reads of _hurd_sigstate. Help it out a little bit
by only reading it once. This also makes for a slightly cleaner code.
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230319151017.531737-32-bugaevc@gmail.com>
Diffstat (limited to 'hurd')
| -rw-r--r-- | hurd/hurd/signal.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/hurd/hurd/signal.h b/hurd/hurd/signal.h index c33f974..662e955 100644 --- a/hurd/hurd/signal.h +++ b/hurd/hurd/signal.h @@ -166,13 +166,15 @@ extern void _hurd_sigstate_delete (thread_t thread); _HURD_SIGNAL_H_EXTERN_INLINE struct hurd_sigstate * _hurd_self_sigstate (void) { - if (THREAD_GETMEM (THREAD_SELF, _hurd_sigstate) == NULL) + struct hurd_sigstate *ss = THREAD_GETMEM (THREAD_SELF, _hurd_sigstate); + if (__glibc_unlikely (ss == NULL)) { thread_t self = __mach_thread_self (); - THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, _hurd_thread_sigstate (self)); + ss = _hurd_thread_sigstate (self); + THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss); __mach_port_deallocate (__mach_task_self (), self); } - return THREAD_GETMEM (THREAD_SELF, _hurd_sigstate); + return ss; } # endif #endif |