aboutsummaryrefslogtreecommitdiff
path: root/gdbsupport
diff options
context:
space:
mode:
Diffstat (limited to 'gdbsupport')
-rw-r--r--gdbsupport/ChangeLog9
-rw-r--r--gdbsupport/gdb_ref_ptr.h2
-rw-r--r--gdbsupport/scoped_fd.h2
-rw-r--r--gdbsupport/scoped_mmap.h9
4 files changed, 14 insertions, 8 deletions
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index cd7033d..78fbbe6 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,12 @@
+2020-04-20 Tom Tromey <tromey@adacore.com>
+
+ * scoped_mmap.h (scoped_mmap): Mark move constructor as noexcept.
+ Use initialization style. Don't call destroy.
+ * scoped_fd.h (class scoped_fd): Mark move constructor as
+ noexcept.
+ * gdb_ref_ptr.h (class ref_ptr): Mark move constructor as
+ noexcept.
+
2020-04-13 Tom Tromey <tom@tromey.com>
* event-loop.c: Move comment. Remove obsolete comment.
diff --git a/gdbsupport/gdb_ref_ptr.h b/gdbsupport/gdb_ref_ptr.h
index c5ef13f..de387f5 100644
--- a/gdbsupport/gdb_ref_ptr.h
+++ b/gdbsupport/gdb_ref_ptr.h
@@ -78,7 +78,7 @@ class ref_ptr
}
/* Transfer ownership from OTHER. */
- ref_ptr (ref_ptr &&other)
+ ref_ptr (ref_ptr &&other) noexcept
: m_obj (other.m_obj)
{
other.m_obj = NULL;
diff --git a/gdbsupport/scoped_fd.h b/gdbsupport/scoped_fd.h
index f40ce8b..ec654df 100644
--- a/gdbsupport/scoped_fd.h
+++ b/gdbsupport/scoped_fd.h
@@ -30,7 +30,7 @@ class scoped_fd
public:
explicit scoped_fd (int fd = -1) noexcept : m_fd (fd) {}
- scoped_fd (scoped_fd &&other)
+ scoped_fd (scoped_fd &&other) noexcept
: m_fd (other.m_fd)
{
other.m_fd = -1;
diff --git a/gdbsupport/scoped_mmap.h b/gdbsupport/scoped_mmap.h
index bab988f..9b74383 100644
--- a/gdbsupport/scoped_mmap.h
+++ b/gdbsupport/scoped_mmap.h
@@ -42,13 +42,10 @@ public:
destroy ();
}
- scoped_mmap (scoped_mmap &&rhs)
+ scoped_mmap (scoped_mmap &&rhs) noexcept
+ : m_mem (rhs.m_mem),
+ m_length (rhs.m_length)
{
- destroy ();
-
- m_mem = rhs.m_mem;
- m_length = rhs.m_length;
-
rhs.m_mem = MAP_FAILED;
rhs.m_length = 0;
}