diff options
Diffstat (limited to 'bfd/elf.c')
| -rw-r--r-- | bfd/elf.c | 23 |
1 files changed, 17 insertions, 6 deletions
@@ -12618,19 +12618,30 @@ _bfd_elf_maybe_function_sym (const asymbol *sym, asection *sec, bfd_vma *code_off) { bfd_size_type size; + elf_symbol_type * elf_sym = (elf_symbol_type *) sym; if ((sym->flags & (BSF_SECTION_SYM | BSF_FILE | BSF_OBJECT | BSF_THREAD_LOCAL | BSF_RELC | BSF_SRELC)) != 0 || sym->section != sec) return 0; + size = (sym->flags & BSF_SYNTHETIC) ? 0 : elf_sym->internal_elf_sym.st_size; + + /* In theory we should check that the symbol's type satisfies + _bfd_elf_is_function_type(), but there are some function-like + symbols which would fail this test. (eg _start). Instead + we check for hidden, local, notype symbols with zero size. + This type of symbol is generated by the annobin plugin for gcc + and clang, and should not be considered to be a function symbol. */ + if (size == 0 + && ((sym->flags & (BSF_SYNTHETIC | BSF_LOCAL)) == BSF_LOCAL) + && ELF_ST_TYPE (elf_sym->internal_elf_sym.st_info) == STT_NOTYPE + && ELF_ST_VISIBILITY (elf_sym->internal_elf_sym.st_other) == STV_HIDDEN) + return 0; + *code_off = sym->value; - size = 0; - if (!(sym->flags & BSF_SYNTHETIC)) - size = ((elf_symbol_type *) sym)->internal_elf_sym.st_size; - if (size == 0) - size = 1; - return size; + /* Do not return 0 for the function's size. */ + return size ? size : 1; } /* Set to non-zero to enable some debug messages. */ |