aboutsummaryrefslogtreecommitdiff
path: root/sim
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2015-10-11 03:56:22 -0400
committerMike Frysinger <vapier@gentoo.org>2015-10-11 03:56:22 -0400
commit7d8a636c9a234354c9b2ecf01b6e405bece190a1 (patch)
treef2b8026a64b5bcbc15f567da26774a1d8ac3290e /sim
parent3f946aa82518e878aea2cba4b6a9bcc651412c5c (diff)
downloadgdb-7d8a636c9a234354c9b2ecf01b6e405bece190a1.zip
gdb-7d8a636c9a234354c9b2ecf01b6e405bece190a1.tar.gz
gdb-7d8a636c9a234354c9b2ecf01b6e405bece190a1.tar.bz2
sim: moxie: fix leakage in error path [BZ #18273]
Reported-by: dcb <dcb314@hotmail.com>
Diffstat (limited to 'sim')
-rw-r--r--sim/moxie/ChangeLog5
-rw-r--r--sim/moxie/interp.c1
2 files changed, 6 insertions, 0 deletions
diff --git a/sim/moxie/ChangeLog b/sim/moxie/ChangeLog
index fe37e82..04b74ce 100644
--- a/sim/moxie/ChangeLog
+++ b/sim/moxie/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-11 Mike Frysinger <vapier@gentoo.org>
+
+ PR sim/18273
+ * interp.c (load_dtb): Close open file in error path.
+
2015-06-23 Mike Frysinger <vapier@gentoo.org>
* configure: Regenerate.
diff --git a/sim/moxie/interp.c b/sim/moxie/interp.c
index 35ee2a7..df92cee 100644
--- a/sim/moxie/interp.c
+++ b/sim/moxie/interp.c
@@ -1273,6 +1273,7 @@ load_dtb (SIM_DESC sd, const char *filename)
if (size != fread (buf, 1, size, f))
{
sim_io_eprintf (sd, "ERROR: error reading ``%s''.\n", filename);
+ fclose (f);
return;
}
sim_core_write_buffer (sd, scpu, write_map, buf, 0xE0000000, size);