diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-05-03 10:54:08 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-05-03 10:55:25 -0400 |
| commit | f08708cbf59ec153eac33d7a2a99ef99f1ca825a (patch) | |
| tree | d5262053baa03a20bedc5d9b8b74b1c968e37a3e /sim/common/sim-utils.h | |
| parent | 5e0a033bd2927a027a5fb2c93d9e403c4f505bd0 (diff) | |
| download | gdb-f08708cbf59ec153eac33d7a2a99ef99f1ca825a.zip gdb-f08708cbf59ec153eac33d7a2a99ef99f1ca825a.tar.gz gdb-f08708cbf59ec153eac33d7a2a99ef99f1ca825a.tar.bz2 | |
sim: add ATTRIBUTE_PRINTF / ATTRIBUTE_NULL_PRINTF where necessary
I finally got the all-targets sim building with Clang, these are all the
instances where an ATTRIBUTE_PRINTF or ATTRIBUTE_NULL_PRINTF attribute
needed to be added to avoid errors like:
/home/simark/src/binutils-gdb/sim/aarch64/../common/sim-profile.c:464:19: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
vfprintf (fp, fmt, ap);
^~~
There are more fixes needed to get everything building, but adding these
attributes is trivial enough, so I send them all in a single patch.
Adding the format attributes introduces some format string errors when
building with GCC (because now format strings are checked), so
corresponding changes are needed to avoid breaking the build. Other
than simple format string specified changes, there is this one:
/home/simark/src/binutils-gdb/sim/aarch64/../common/hw-events.c: In function 'hw_event_queue_schedule':
/home/simark/src/binutils-gdb/sim/aarch64/../common/hw-events.c:95:15: error: too many arguments for format [-Werror=format-extra-args]
95 | NULL, dummy);
| ^~~~~
We can fix it and avoid using a dummy variable by simply calling
hw_event_queue_schedule_tracef instead of
hw_event_queue_schedule_vtracef.
sim/arm/ChangeLog:
* armdefs.h (ARMul_ConsolePrint): Use format attribute.
* wrapper.c (op_printf): Likewise.
sim/bfin/ChangeLog:
* interp.c (sim_open): Adjust format string specifier.
sim/common/ChangeLog:
* hw-events.h (hw_event_queue_schedule_tracef): Use format attribute.
(hw_event_queue_schedule_vtracef): Likewise.
* hw-tree.h (hw_tree_vparse): Likewise.
* sim-profile.c (profile_vprintf): Likewise.
* sim-trace.c (dis_printf): Likewise.
* sim-trace.h (trace_printf): Likewise.
(trace_vprintf): Likewise.
* sim-utils.h (sim_do_commandf): Likewise.
* hw-events.c (hw_event_queue_schedule): Use
hw_event_queue_schedule_tracef.
sim/rx/ChangeLog:
* trace.c (op_printf): Likewise.
sim/v850/ChangeLog:
* interp.c (sim_open): Adjust format string specifier.
Change-Id: I1445115ce57db15bb8e35dca93014555e7555794
Diffstat (limited to 'sim/common/sim-utils.h')
| -rw-r--r-- | sim/common/sim-utils.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sim/common/sim-utils.h b/sim/common/sim-utils.h index f089245..9cc19f5 100644 --- a/sim/common/sim-utils.h +++ b/sim/common/sim-utils.h @@ -68,7 +68,8 @@ struct bfd *sim_load_file (SIM_DESC sd, const char *myname, int lma_p, sim_write_fn do_load); /* Internal version of sim_do_command, include formatting */ -void sim_do_commandf (SIM_DESC sd, const char *fmt, ...); +void sim_do_commandf (SIM_DESC sd, const char *fmt, ...) + ATTRIBUTE_PRINTF (2, 3); /* These are defined in callback.c as cover functions to the vprintf |